Repository navigation
2.0.0-rc.8: Lauren's 0317eb8, a brand comes from a type guard, not an as cast - #28
Merged
Merged
Conversation
All three components move from 99743e9 to 0317eb8. Upstream changed only pstack's typescript-best-practices skill (pstack #700): the Branded types row says a brand comes from a verifying type guard, never from `as`, and the parseAgentId example in references/patterns.md now narrows through an isAgentId type guard and returns the input with no cast. 182f2ce (#637) sits between the two pins but touches only paths tools/upstream.json excludes. bun tools/sync.mjs updated both files cleanly, and each is byte-identical to upstream at 0317eb8. No substitution or fork names them, and the 15 declared forks were left alone. cursor-team-kit and thermos synced with no file changes.
VERSION, the manifests, and package.json move to 2.0.0-rc.8. CHANGES.md gets the entry with its behavior-delta table. NOTICE.md, NOTICE-skills.md, and the README point at upstream 0317eb8, and the README's pinned installer command names the new tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t3-pstack moves to Lauren Tan's pstack at cursor/plugins
0317eb8for all three components. Only pstack changed upstream, in one commit, and its version stays 0.15.25:typescript-best-practicesbuilt its branded-type example with theascast that its own "Noascasts" row warns against. The Branded types row now says a brand comes from a verifying type guard (input is AgentId), never fromas, andreferences/patterns.md'sparseAgentIdnarrows through anisAgentIdguard and returns the input with no cast. #700's copies underharness/pstack/claude-code/sit outside every synced component.pstack #637 also lands between the two pins. It changed only upstream's README and
docs/harness/claude-code.md, whichtools/upstream.jsonexcludes, so a dry run at its commit changed no file.This is Lauren's text plus mechanical version lines. No substitution or fork changed. Both skill files are byte-identical to upstream's at
0317eb8.Commits
bun tools/sync.mjsmoves each component's pin from99743e9to0317eb8and updatestypescript-best-practices/SKILL.mdandreferences/patterns.mdcleanly. No rule intools/substitutions.jsonand no entry intools/forks.jsonnames either file, and the 15 declared forks were left alone. cursor-team-kit and thermos synced with no file changes.VERSIONand the manifests move to 2.0.0-rc.8. CHANGES gets the entry with its behavior-delta table. NOTICE, NOTICE-skills, and the README point at0317eb8, and the README's pinned installer command names the new tag.On T3
The change names no Cursor or T3 mechanism, so it reads the same on T3 as on Cursor. The new row agrees with the skill's existing "No
ascasts" row and withprinciple-type-system-discipline's rule to validate a brand once at creation. No port-only file quotes the oldinput as AgentIdexample.Checks
bun tools/sync.mjs <component> 0317eb8 --dry-runfor pstack, cursor-team-kit, and thermos: exit 0, no undeclared fork, no denylist hit, no unmatched substitution. At the pin, pstack reads 118 unchanged files and the same 15 declared forks with 547 changed lines as before.bun tools/generate.mjs --check: 17 generated files current, and the hooks freeze check passes. Neither hooks file differs fromorigin/main.GIT_CONFIG_GLOBAL=/dev/null bun test tests/ --timeout 30000: 550 pass, 46 skip, 0 fail.bun run typecheck,bun test orch watch-pr check-plan.test.ts(119 pass), and the Prettier check all pass.t3-sheet.mjsagainst this machine's sheet and catalog: every role line parses and dispatches.Note
Low Risk
Documentation and skill guidance only; no runtime, auth, or orchestration code changes.
Overview
Release 2.0.0-rc.8 bumps version manifests and repins all three
cursor/pluginscomponents intools/upstream.jsonfrom99743e9to0317eb8.The only functional content change is upstream pstack #700 in
typescript-best-practices: the Branded types rule now states that a brand must come from a verifying type guard (input is AgentId), not anascast, andreferences/patterns.mdaddsisAgentIdsoparseAgentIdnarrows and returns withoutinput as AgentId. NOTICE/README/CHANGES and license upstream links are updated to match the new pin; cursor-team-kit and thermos sync with no file diffs beyond the SHA.Reviewed by Cursor Bugbot for commit 7939f1a. Bugbot is set up for automated code reviews on this repo. Configure here.