Use correct From address when sending MDNs and unencrypted Bcc - #8716
Merged
Merged
Conversation
link2xt
commented
Sep 18, 2026
| mimefactory.recipients() | ||
| }; | ||
| let rendered_msg = Box::pin(mimefactory.render(context)).await?; | ||
| let from = smtp.from.as_ref().context("No From address, not connected")?.to_string(); |
Collaborator
Author
There was a problem hiding this comment.
Passing this From address of the current connection to render() now.
link2xt
force-pushed
the
link2xt/mdn-from-address
branch
from
September 18, 2026 20:04
8d30ba0 to
7f3efa0
Compare
link2xt
changed the title
link2xt
marked this pull request as ready for review
September 18, 2026 20:23
link2xt
marked this pull request as draft
September 18, 2026 20:36
link2xt
force-pushed
the
link2xt/mdn-from-address
branch
from
September 18, 2026 20:54
dd92ab0 to
a09d0aa
Compare
link2xt
marked this pull request as ready for review
September 18, 2026 21:10
This comment was marked as outdated.
This comment was marked as outdated.
link2xt
force-pushed
the
link2xt/mdn-from-address
branch
2 times, most recently
from
September 19, 2026 07:19
2c8f098 to
f9272f1
Compare
link2xt
commented
Sep 19, 2026
hpk42
reviewed
Sep 19, 2026
link2xt
force-pushed
the
link2xt/mdn-from-address
branch
from
September 19, 2026 15:37
f9272f1 to
43f4c60
Compare
hpk42
approved these changes
Sep 19, 2026
hpk42
left a comment
hpk42
left a comment
Contributor
There was a problem hiding this comment.
would be good if the get_primary_self_addr calls could be avoided in the tests (including in render_queued_mail_with_context) by calling a first_smtp_from_candidate or so, and picking it like connect_configured does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8705
MDNs should use the From address of the currently connected transport rather than
ConfiguredAddrviaget_primary_self_addr.ConfiguredAddrshould be removed eventually (#8572)Need to merge this before release, otherwise MDNs will be broken. Bcc-self for unencrypted messages is another fix, but not so important because unencrypted messages with multi-relay are likely to fail anyway.