fix: do not send a sync message when changing "configured_addr" - #8703
Merged
Merged
Conversation
link2xt
force-pushed
the
link2xt/dont-sync-configured_addr
branch
from
September 16, 2026 19:41
78609fa to
0161855
Compare
link2xt
marked this pull request as ready for review
September 16, 2026 19:42
link2xt
force-pushed
the
link2xt/dont-sync-configured_addr
branch
2 times, most recently
from
September 16, 2026 19:50
6612faa to
138c23e
Compare
link2xt
marked this pull request as draft
September 17, 2026 06:50
link2xt
force-pushed
the
link2xt/dont-sync-configured_addr
branch
from
September 17, 2026 07:04
138c23e to
4cfe0d8
Compare
link2xt
commented
Sep 17, 2026
|
|
||
| /// Promotes `addr` on `alice` and syncs the transport update to `alice2`, | ||
| /// whose own primary transport must stay unchanged. | ||
| async fn promote_transport_and_sync( |
Collaborator
Author
There was a problem hiding this comment.
This code is moved into the test above, but with checks like > for add_timestamp replaced with assert_eq!
link2xt
force-pushed
the
link2xt/dont-sync-configured_addr
branch
from
September 17, 2026 07:06
4cfe0d8 to
5d5e4de
Compare
link2xt
marked this pull request as ready for review
September 17, 2026 07:06
link2xt
force-pushed
the
link2xt/dont-sync-configured_addr
branch
from
September 17, 2026 12:44
5d5e4de to
134908b
Compare
link2xt
force-pushed
the
link2xt/dont-sync-configured_addr
branch
from
September 17, 2026 13:29
134908b to
0d15a77
Compare
link2xt
commented
Sep 17, 2026
| /// and does not bump sending transport `add_timestamp`. | ||
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] | ||
| async fn test_promote_transport_same_second() -> Result<()> { | ||
| async fn test_no_configured_addr_synchronization() -> Result<()> { |
Collaborator
Author
There was a problem hiding this comment.
No need to look at the test in detail, it is going to be removed anyway when ConfiguredAddr is not possible to set anymore.
hpk42
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending transport is not synchronized since cd42efb (PR #8510) so there is no need to send a sync message when the sending transport is changed.