block reading snapshots outside of the data dir - #21
Open
adkron wants to merge 1 commit into
Open
Conversation
The current implementation does not try to look at the traversals and allowed me to read files outside of the data-directory. This could lead to a data leak if the wrong person was able to get tcp access. The path is now checked with `Path.safe_relative/2` to ensure that the path stays in the starting directory or down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation does not try to look at the traversals and allowed me to read files outside of the data-directory. This could lead to a data leak if the wrong person was able to get tcp access. Since this is exposed through TCP I think that is possible.
The path is now checked with
Path.safe_relative/2to ensure that the path stays in the starting directory or down.