Install cmrel from master and drop the checkout requirement - #2280
Draft
wallrj wants to merge 1 commit into
Draft
Conversation
The release process told release managers to install cmrel with `@latest` and then run it from a clone of cert-manager/release. Until this week `@latest` resolved to a tag from April 2024, and that binary fails at the first step of publish because the publish job now refuses to install an unpinned cmrel. Once cert-manager/release#376 merges, cmrel also carries its own Cloud Build config, so the clone is only needed for the chart signing script. Tell release managers to install from `@master` immediately before a release and warn them not to build from a local checkout, because an untracked file makes the binary "dirty" and the publish job rejects it. Co-Authored-By: Claude Fable 5.1 <[email protected]> Signed-off-by: Richard Wall <[email protected]>
cert-manager-prow
Bot
added
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
size/S
41 tasks
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/hold until cert-manager/release#376 merges, because the new text says
cmrelno longer needs the checkout.Release managers install
cmrelwithgo install ...@masterand no longer run it from a clone ofcert-manager/release. The clone stays, but only for the chart signing script.Why
The v1.21.2 release found that
go install ...@latestgave a binary from April 2024 that cannot publish, because the publish job now refuses to install an unpinnedcmrel(cert-manager/release#334). Details: cert-manager/cert-manager#9237 (comment)Tagging
cert-manager/release(v1.13.0) fixes@latestfor now, but a tag and a checkout are two things to keep in sync, and nothing checks that they match. Building from the checkout is not safe either: Go stamps the binaryvcs.modified=trueifgit statusshows anything, including untracked files, and the pin then refuses to run. Evidence is in cert-manager/release#376.What changes
@master, with two sentences on why, and a warning not to build from a local checkout.cd releaseis gone because nothing before the chart step needs it.cmrel publishcommands lose their "must be run from the release repo folder" comment. The chart script keeps its comment.[Claude Fable 5.1]