Add a release step to tell contributors their change is available - #2279
Draft
wallrj wants to merge 1 commit into
Draft
Add a release step to tell contributors their change is available#2279wallrj wants to merge 1 commit into
wallrj wants to merge 1 commit into
Conversation
After a release we comment on each included PR, and on each issue it closes, so the author and reporter know the change is available and can verify it. This was done by hand for v1.21.0-beta.0 and not at all for v1.21.1, because the release process did not list it. Add it as a step after the Slack announcement, using the script from cert-manager/release#329. Co-Authored-By: Claude Fable 5.1 <[email protected]> Signed-off-by: Richard Wall <[email protected]>
cert-manager-prow
Bot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
size/S
41 tasks
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a step to the release process: after the Slack announcement, tell the authors of the included PRs and the reporters of the issues they close that the change is available and ask them to verify it.
This was done by hand for v1.21.0-beta.0, about 40 comments, and not at all for v1.21.1 because the process did not list it. The step uses the script in cert-manager/release#329.
/hold until cert-manager/release#329 merges, so the link in the doc works.
Part of cert-manager/cert-manager#9237.
[Claude Fable 5.1]