Add script to ping PR authors and issue reporters after a release - #375
Closed
wallrj wants to merge 1 commit into
Closed
Add script to ping PR authors and issue reporters after a release#375wallrj wants to merge 1 commit into
wallrj wants to merge 1 commit into
Conversation
After a release is published we tell the authors of the included PRs, and the reporters of the issues those PRs close, that the change is available and ask them to verify it. For v1.21.0-beta.0 that meant about 40 comments posted by hand, and for v1.21.1 it was not done at all. hack/ping-release-prs.sh posts those comments. It is idempotent: it skips any PR or issue that already has a comment linking to the release, and it reads comments 100 at a time so a long thread does not hide an earlier ping. It skips issues reported by the PR author or by a member of the repository's organization. Cherry-pick PRs are resolved to the PR they were picked from, so for a patch release you pass the release-branch PR numbers from the release notes and the pings land on the original PR and its linked issues, where the contributor and reporter are watching. The wording says "pre-release" or "release" to match the GitHub release. Co-Authored-By: Claude Fable 5.1 <[email protected]> Signed-off-by: Richard Wall <[email protected]>
Contributor
|
Skipping CI for Draft Pull Request. |
cert-manager-prow
Bot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
size/L
Member
Author
|
Closing. I pushed these changes to #329 instead, which is the same script on the work-account fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #329, which is the same script on my work account's fork. This PR adds what the v1.21.2 release needed.
What does this do?
Adds
hack/ping-release-prs.sh. After a release is published, it posts a comment on each included PR telling the author the change is available, and a comment on each issue those PRs close asking the reporter to verify the fix.It is idempotent. It skips any PR or issue that already has a comment linking to the release, and it reads 100 comments per page so a long thread does not hide an earlier ping.
Why
Changes since #329
Usage
Dry run for v1.21.2
14 PR comments and 3 issue comments would be posted.
A follow-up website PR adds this as a step in the release process.
[Claude Fable 5.1]