Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged in, will:
Changes in code:
fromLibrarytofromLibrariesto make that clear and then just picked the data byidand changed places in the code where needed.alterParemetersthat was copied from VT2ER but not used (as it was only relevant for the regular Virtual Tour) and put the existing part into amigrateScenesfunction.fixHotspotInteractionPositionsfunction that was added to VT2ER recently for NDLA Virtual Tour, called inalterParametersl10nDefaultsthat had been neglected before, to set default language strings (as VT2ER would, as it is common practice to do that in H5P content type upgrade scripts).