Skip to content

Fix Hotspot interaction positions #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janlindso wants to merge 1 commit into from
Closed

Fix Hotspot interaction positions #3300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions sourcecode/apis/contentauthor/app/Http/Controllers/Admin/AdminContentMigrateController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,65 @@ private function alterParameters(string $parameters, string $libraryName): strin
*/
}

if (isset($contentJson["threeImage"]["scenes"])) {
$this->fixHotspotInteractionPositions($contentJson["threeImage"]["scenes"]);
}

return json_encode($content, flags: JSON_THROW_ON_ERROR);
}

/**
* Compensate for `transform: translate(-50%, -50%);` set on "nav buttons" shown as hotspot other than GoToScene
* in static scenes and panorama scenes.
*
* @param array &$scenes The scenes array to modify.
*/
private function fixHotspotInteractionPositions(&$scenes)
{
foreach ($scenes as &$scene) {
if ($scene["sceneType"] === "360" || !isset($scene["interactions"])) {
continue;
}

foreach ($scene["interactions"] as &$interaction) {
if (
$interaction["showAsHotspot"] !== true ||
!isset($interaction["action"]["library"]) ||
$interaction["action"]["library"] === "H5P.GoToScene 0.1"
) {
continue;
}

$positions = isset($interaction["interactionpos"])
? explode(",", $interaction["interactionpos"])
: [];
$sizes = isset($interaction["hotspotSettings"]["hotSpotSizeValues"])
? explode(",", $interaction["hotspotSettings"]["hotSpotSizeValues"])
: [];

if (count($positions) < 2 || count($sizes) < 2) {
continue;
}
// `interactionpos` is something like "1.234%,5.678%"
$left = floatval(trim($positions[0]));
$top = floatval(trim($positions[1]));

// `hotSpotSizeValues` is something like `1.234,5.678"
$width = floatval($sizes[0]);
$height = floatval($sizes[1]);

$newLeft = $left + $width / 2;
$newTop = $top + $height / 2;

$interaction["interactionpos"] = "{$newLeft}%,{$newTop}%";
}

unset($interaction);
}

unset($scene);
}

/**
* @return array<array{lti_launch_url: string, title: string, content_id: string, update_url: string}>
* @throws GuzzleException|JsonException|RuntimeException
Expand Down
Loading