Use unique token for helper lookups - #25
Open
chadhietala wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chadhietala
changed the title
chadhietala
force-pushed
the
fix-helper-clobbering
branch
from
June 6, 2022 14:15
2640f3f to
00d3910
Compare
chadhietala
marked this pull request as ready for review
June 6, 2022 14:17
chadhietala
force-pushed
the
fix-helper-clobbering
branch
from
June 6, 2022 14:18
00d3910 to
7670429
Compare
chadhietala
force-pushed
the
fix-helper-clobbering
branch
from
June 6, 2022 15:05
7670429 to
418d5b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that currently helpers are created on "first one wins" semantics because the map is keyed off of name. This PR fixes the issue by creating a unique token from
SourceLocationto make sure we don't drop helpers on the floor.I'm still vetting these changes locally.