Add precision, recall and AUROC scorers; fix nondeterministic weight fitting - #71
Merged
Merged
Conversation
Collaborator
Author
|
Looks good. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New classification scorers
precision,recallandroc_aucfor binary and multiclass problems. For multiclass, precision and recall are macro averages, and AUROC is a macro one-vs-rest average.average_precision_scorenow also works for multiclass (macro one-vs-rest).partial_fitcalls.partial_fitnow also updatesparameters_, so the new scorer is used by final model selection.Fix:
Floor/Ceilbroke weight optimizationThese nodes were flagged as weighted but left out of
get_weights(). During fitting, evaluation still took a weight for them. That shifted every later weight to the wrong node and read past the end of the parameter array. As a result, fits depended on uninitialized memory, and runs with the same seed could differ. The fix is that only weighable node types take a weight during evaluation.test_fixed_seed_produces_identical_brush_runsnow passes consistently.Docs and tests
partial_fit.