Fix/random state, solving #29 - #70
Merged
Merged
Conversation
Collaborator
Author
|
Looks good |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the determinism and reproducibility of the Brush library by ensuring that a fixed random seed produces identical results across runs, regardless of thread scheduling. The changes affect both the C++ and Python code, update the handling of random number generation, and add comprehensive tests to verify reproducibility.
Deterministic Randomness and Reproducibility
Rnd) now resets its internal Box-Muller cache state (has_spare_normal,spare_normal) when seeded, and its Gaussian sampling (gasdev) implementation is made thread-safe and deterministic.random_stateis provided, making Python-side runs reproducible as well.random_stateis updated to clarify that a fixed integer ensures full reproducibility, including for multi-island runs.Testing and Validation
params.set_random_state(42)) in all relevant places, and a new test (FixedSeedProducesIdenticalRuns) asserts that repeated runs with the same seed produce identical models, weights, and populations.