Run records, recorded-input lookup, qc metagene, docs by section - #2
Merged
Merged
Conversation
- Every producer, every `faba all` step and `faba qc` writes
`{job}.run.json`: version, command line, status, inputs (the path as
given plus the resolved file when a symlink differs), every effective
option, and the outputs, found by diffing the output directory.
- `pileup`, `metagene` and `pwm` fall back to the GFF or genome named in
the run record next to their input when the flag is omitted. The
lookup prefers the file the run actually read when a symlink has since
been repointed. `qc` carries the annotation and genome forward and no
longer copies the input's records into the new fileset.
- `qc --interactive` draws a metagene under the histogram: all sites
behind, kept sites in front, on region widths fixed by all sites so the
axis does not move with the thresholds. The annotation loads on a
thread; `--gff` overrides the recorded one.
- The threshold table's counts are renamed to say what they count
("sites that fail": this / only this) and the first-failed-check column
is dropped.
- `faba docs` takes keywords: a subcommand, a section number, or a word
of a heading prints just those sections.
- The profiling write-up is corrected against the code (read filters per
command, floors the producers do apply, discovery cell sets, pwm and
pileup behavior), and stale help text and rustdoc are fixed at the
source.
- Clippy lints raised by the newer toolchain are fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dartseq,atoi,apa,count,depth,snp), everyfaba allstep andfaba qcwrites{job}.run.jsoninto its output directory: version, command line, status, inputs, every effective option, and the files it wrote. Each input keeps the path as given and, when a symlink makes them differ, the resolved file. Outputs are found by diffing the directory before and after the run, not by a hand-kept list.faba allstill writespipeline_summary.jsonfor the whole run.pileup(--gtf),metagene(-g) andpwm(-f) fall back to the GFF or genome recorded next to their input. The lookup uses the path as given while it still leads to the file the run read, and the resolved file if the link was repointed or removed (with a warning).qccarries the annotation and genome into its own record and no longer copies the input's records, which describe the input directory.qc --interactiveshows a metagene below the threshold histogram, with all sites behind and kept sites in front. Region widths are fixed from all putative sites, so the axis does not shift as thresholds move. The annotation is read on a thread;--gffoverrides the recorded one. The saved figure includes the metagene.faba docsby keyword. A subcommand name, a section number or a word from a heading prints only the matching sections. The topic name still prints the whole write-up.apaanddepthdo apply, the cell set used for discovery, andpwm/pileupbehaviour. The stale help text and rustdoc are fixed at the source.Testing
qcwrites its own record and does not copy the input's.pileup/metagene/pwmfound their files through it, andqcforwarded them.