Gene rule reads only the gene part and never cuts a coordinate - #22
Merged
Merged
Conversation
The gene rule looked at the whole row name, so compound rows whose coordinate sits on a contig with '_' were cut at the contig name: chr1_CTG_random:12345/baf/alt was keyed on random:12345/baf/alt, and a site row ENSG_GENE1/m6a/chr1_CTG_random:123/methylated likewise. It now reads only a row's first '/'-segment, its gene part, and keeps the rest as written. A gene part that is a coordinate, a position chr:pos or a locus chr:start-end (legume-genomic-types is_region), is left whole. Mixed axes take the same rule. Release 0.7.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gene rule looked at the whole row name, so compound rows whose coordinate sits on a contig with
_were cut at the contig name:chr1_CTG_random:12345/baf/altwas keyed onrandom:12345/baf/alt, andENSG_GENE1/m6a/chr1_CTG_random:123/methylatedlikewise./-segment (its gene part) and keeps the rest as written:ENSG_GENE1/count/splicedstill becomesGENE1/count/spliced.chr:posor a locuschr:start-end(legume-genomic-types 0.5.2is_region), is left whole.Mixedaxes use the same rule after the locus key.Version 0.7.1.