Revert the case-folded locus fallback for frozen dictionaries - #20
Merged
Merged
Conversation
This reverts commit 916ea02 (#19), never published. The fallback matched locus keys with the chromosome case ignored inside the frozen loader, loosening Locus/Mixed matching for every caller, without saying which rows matched which way. Case can tell scaffolds apart in some assemblies. Old dictionaries with lowercased locus keys should be migrated once, explicitly, or retrained; the loader stays strict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #19, which was merged but never published.
The fallback matched locus keys with the chromosome case ignored inside the frozen loader. That loosens
Locus/Mixedmatching for every caller without saying which rows matched which way, and case can tell scaffolds apart in some assemblies. Old dictionaries saved with lowercased locus keys should be migrated once, explicitly (with a report of every renamed key), or retrained; the loader stays strict.Version returns to 0.6.24 (published); nothing to release.