Repository navigation
Drop the format check from CI - #8
Merged
Merged
Conversation
Formatting is no longer a merge gate, so the format job, the formatter installation in both workflows, and check_format.py are gone. The template workflow no longer runs the check either; it still builds and tests both linkagings over every scope. The .clang-format file stays as the reference for editors and clang-format -i, and the README now says so and counts 7 CI jobs instead of 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
不再把格式作为合并门禁。
ci.yml：删除formatjob，剩native矩阵（5 个检查）和sanitizer。template.yml：删除 clang-format 安装步骤。test_template.py：不再调用check_format.py，仍然对两种链接方式跑全部范围。.github/scripts/check_format.py（唯一用途就是那个检查）。README.md：本地验证清单去掉 format 一行，Job 数 8 → 7，新增一句说明格式不入 CI。.clang-format保留，作为编辑器和clang-format -i的依据，评审时按需处理。验证
ci.yml2 个 job、template.yml1 个、release.yml2 个。python .github/scripts/test_template.py本地跑通（exit 0）：初始化 AwesomeApp 后 static/Debug 与 shared/Release 两轮--scope all全部通过。