Skip to content

test(discovery): validate context cancellation for ReverseDNS - #156

Open
mendsec wants to merge 1 commit into
developfrom
fix/reverse-dns-cancellation-test-9384047681915600896
Open

mendsec wants to merge 1 commit into
developfrom
fix/reverse-dns-cancellation-test-9384047681915600896

Conversation

@mendsec

@mendsec mendsec commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Added TestReverseDNSCancellationActive to pkg/discovery/net_test.go to verify that ReverseDNS does not leak goroutines during early cancellation. Checked by taking a baseline of goroutines before running ReverseDNS and ensuring that it returns to within a threshold of <= 3 after the background context cancels.


PR created automatically by Jules for task 9384047681915600896 started by @mendsec

Adds `TestReverseDNSCancellationActive` to `pkg/discovery/net_test.go` to verify that no goroutines leak when `ReverseDNS` is cancelled prematurely. Checked using a threshold on `runtime.NumGoroutine()`.

Co-authored-by: mendsec <[email protected]>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant