Friedland Recreation Chapter 8 - #1121
Conversation
Update prep_sphinx_conf.py
Update chapter_7.rst
Update chapter_7.rst
|
That looked horrible and I fixed it. I copied the results from the actual run and forgot to replace with the values from the text.
I don't know that this is a fair comment lol, you are looking at columns that are just data, of course it's not "useful". When I was constructing this workbook, I was thinking what would be most useful to a reader if they wanted to recreate the examples in the text, and do only that. The chapter 11 stuff is doing so much more than teaching users how to use the package, it's actually doing reconstruction with exhibits, and imo, is too much. It's actually harder for the users to figure out exactly which line of code will recreate the numbers. I'm not saying we shouldn't go there, but I don't think that is a priority now. If we think this is the MVP and are all aligned, than I will do that, but we should all come to an agreement here. Anyways, we have a few chapters in now, and they all look widely different. We will need to decide how to standardize them. Please take another look and see if I missed anything... |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 577a718. Configure here.
|
Ok. I reworked the exhibits and now they look much more like Chapter 7's now. Please take a look and let me know of any other feedback. |
|
exhibit_i_s1["CDF Reported (4)"] = origin_cdf(auto_bi["Reported Claims"], reported_pattern).values
exhibit_i_s1["CDF Paid (5)"] = origin_cdf(auto_bi["Paid Claims"], paid_pattern).valuesi've been harping on this to the other collaborators, so i gotta be fair here and give you the same feedback. we should use the chainladder API whenever we can. so either |


Summary of Changes
Populationtofriedland_gl_self_insurerEarned Premiumtofriedland_us_auto_chg_prod_mixEarned Premiumtofriedland_us_auto_steady_statefriedland_us_auto_steady_state.csvRelated GitHub Issue(s)
#588
#919
Additional Context for Reviewers
Preview here
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
Changes core triangle date initialization logic used by
load_sampleand user triangles; scope is narrow (one format string) but affects development lag axes.Overview
Adds Friedland Chapter 8 to the Jupyter Book TOC (
friedland/chapter_8.ipynb) for the recreation series tied to issue #588.Triangle development dates: When
development_formatis%Y-12-31, development is now re-normalized to calendar year-end viato_period("Y")andto_timestamp(how="e")in_set_development, addressing year-end parsing issues from #919.Bundled Friedland samples: Manifest and CSVs gain extra measures—
Populationonfriedland_gl_self_insurer(with existing%Y-12-31format)—and Earned Premium onfriedland_us_auto_chg_prod_mixandfriedland_us_auto_steady_state, with steady-state claim rows corrected for accident-year alignment.Reviewed by Cursor Bugbot for commit 27d6395. Bugbot is set up for automated code reviews on this repo. Configure here.