fix(kms): make the AWS KMS signer support dynamic-fee transactions#792
Open
renatomaia wants to merge 3 commits into
Open
fix(kms): make the AWS KMS signer support dynamic-fee transactions#792renatomaia wants to merge 3 commits into
renatomaia wants to merge 3 commits into
Conversation
renatomaia
force-pushed
the
fix/awsKmsDynamicFeeSigning
branch
2 times, most recently
from
July 22, 2026 11:43
c71f0be to
26060af
Compare
renatomaia
force-pushed
the
fix/awsKmsDynamicFeeSigning
branch
from
July 22, 2026 13:04
26060af to
e412f81
Compare
|
Old tests needed to fill in the ARN variable with a valid AWS KMS instance to work. That would cost money and expose secrets, so it is disabled by default. But maybe with the localstack setup it could be enabled or refactored, any thoughts on that? |
renatomaia
force-pushed
the
fix/awsKmsDynamicFeeSigning
branch
from
July 22, 2026 14:56
5c62c67 to
c606f7f
Compare
renatomaia
force-pushed
the
fix/awsKmsDynamicFeeSigning
branch
from
July 22, 2026 19:58
c606f7f to
9092af5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The AWS KMS factory is still built with
types.NewEIP155Signer(chainId). That signer is legacy-only. Direct geth bindings can create dynamic-fee transactions whenGasPriceis nil and the chain has a base fee, which is the normal EIP-1559 path. In that case the KMS code hashes and attaches the signature using the wrong signer family.Tests
types.DynamicFeeTx, the transaction is signed withtypes.LatestSignerForChainID, and sender recovery succeeds.LOCALSTACK_KMS_ENDPOINTis set.