feat: optional signing providers - #2295
Conversation
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
…to register Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
pawelstepien-da
changed the title
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
…tional-signing-providers Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
…tional-signing-providers Signed-off-by: Pawel Stepien <[email protected]> # Conflicts: # wallet-gateway/remote/src/user-api/rpc-gen/index.ts
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
| } | ||
|
|
||
| const hasSigningDb = process.argv.slice(2).includes('signing-db') | ||
| // TODO check if I can get rid db and signing-db arguments. |
There was a problem hiding this comment.
@mjuchli-da Do you think we can remove arguments 'db' and 'signing-db'? If not, then I will just remove TODO comment.
| Each signing provider can be explicitly disabled by setting its corresponding | ||
| environment variable to `true`: | ||
|
|
||
| - `WALLET_KERNEL_SIGNING_DISABLED` | ||
| - `PARTICIPANT_SIGNING_DISABLED` | ||
| - `FIREBLOCKS_SIGNING_DISABLED` | ||
| - `BLOCKDAEMON_SIGNING_DISABLED` | ||
| - `DFNS_SIGNING_DISABLED` | ||
| - `SECUROSYS_SIGNING_DISABLED` |
There was a problem hiding this comment.
why environment variables rather than set from the config file? I think we should aim to use the config whenever possible since it is self-documenting (with JSON schema). The only time we cant put something in the config file is if it has to be a secret (like an API key)
I suggest we add a new root-level config block for providers so users can do something like
{
providers: {
wallet_kernel: {
enable: false
},
participant: {
enable: false
},
fireblocks: {
enable: true,
api_path: "https://api.fireblocks.io/v1",
},
blockdaemon: {
enable: true,
capi2: "canton:testnet"
}
}There was a problem hiding this comment.
I think I wanted to have everything that controls whether signing driver is registered in one place.
I agree that it's better have non-sensitive signing provider configuration in WG config while keeping sensitive in env vars. I will rewrite it.
2 participants
No description provided.