Improve client ip rate limits - #6853
Conversation
Add ability to disable fallback for headers Remove default rate limit when no ip is known and instead just count it through a metric (we count on the global rate limiter to avoid SVs that don't extract the ip correctly to just rate limit everyone more aggressivly) [ci] Signed-off-by: Nicu Reut <[email protected]>
599d3ae to
565abe6
Compare
[ci] Signed-off-by: Nicu Reut <[email protected]>
|
I would expect the headers be disabled by default. As an operator I can't disable something if I don't know it exists. I can't be sure more headers won't be added in the future either. Vice-versa, if I need the app to handle these headers I know this and I'll go to configs or docs to figure if the app supports it and how to enable. |
The per ip rate limits should be enabled by default therefore the reasoning for the default headers as well.
I would expect that to be the scope for release notes.
That would go against the per ip rate limits are enabled by default. The other reasoning is that these not being configured correct is low risk. Either you get the wrong value and rate limits gets enforced more aggressive, which would lead us to identify that issue, or users can bypass them and we would see that in the overall rate, and global rate limits are there to protect against such issues. |
This leaves misconfiguration as a possibility (possibly unnoticed) while the software could force an operator to be tuned based on the operator's infra-setup explicitly. |
Add ability to disable fallback for headers
Remove default rate limit when no ip is known and instead just count it through a metric (we count on the global rate limiter to avoid SVs that don't extract the ip correctly to just rate limit everyone more aggressivly)
[ci]
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines