fix: added missing feature flag for multisync - #6809
Merged
moritzkiefer-da merged 14 commits intoAug 20, 2026
Conversation
jarekr-da
force-pushed
the
jarekr/multisync-flag
branch
from
August 19, 2026 08:13
d6db630 to
e9e121e
Compare
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
jarekr-da
force-pushed
the
jarekr/multisync-flag
branch
from
August 19, 2026 08:23
92d67df to
d9e53ee
Compare
moritzkiefer-da
left a comment
Contributor
There was a problem hiding this comment.
thx looks reasonable to me, you are missing an updateTestConfigForParallelRuns and there is a stray println
| filtersForAnyParty = None, | ||
| verbose = true, | ||
| ) | ||
| println(eventFormat) |
Contributor
There was a problem hiding this comment.
you probably don't want a random println here
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Contributor
|
you're still missing |
Signed-off-by: jarekr-da <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
EnableMultiSynchronizerflag to localnet bootstrap (app-synchronizer.sc)(After protocol switch to 35 it is mandatory now)
Also test added - there was already ReassignmentTest - but was not using localnet (that is why the problem was not detected).
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines