Skip to content

fix: added missing feature flag for multisync - #6809

Merged
moritzkiefer-da merged 14 commits into
canton-network:mainfrom
jarekr-da:jarekr/multisync-flag
Aug 20, 2026
Merged

fix: added missing feature flag for multisync#6809
moritzkiefer-da merged 14 commits into
canton-network:mainfrom
jarekr-da:jarekr/multisync-flag

Conversation

@jarekr-da

@jarekr-da jarekr-da commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This PR adds EnableMultiSynchronizer flag to localnet bootstrap (app-synchronizer.sc)
(After protocol switch to 35 it is mandatory now)

Also test added - there was already ReassignmentTest - but was not using localnet (that is why the problem was not detected).

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>
Signed-off-by: jarekr-da <[email protected]>

@moritzkiefer-da moritzkiefer-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx looks reasonable to me, you are missing an updateTestConfigForParallelRuns and there is a stray println

filtersForAnyParty = None,
verbose = true,
)
println(eventFormat)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably don't want a random println here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(oops) removed

Signed-off-by: jarekr-da <[email protected]>
@moritzkiefer-da

Copy link
Copy Markdown
Contributor

you're still missing sbt updateTestConfigForParallelRuns

@moritzkiefer-da moritzkiefer-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Jarek!

@moritzkiefer-da
moritzkiefer-da merged commit 49c7708 into canton-network:main Aug 20, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants