Skip to content

Add fund manager blacklist and dev fund coupon mint delay - #6793

Open
zheli wants to merge 13 commits into
canton-network:staging-0.8.0from
bitdynamics-ab:zheli/delay-devfund-coupon-collection/6722
Open

Add fund manager blacklist and dev fund coupon mint delay#6793
zheli wants to merge 13 commits into
canton-network:staging-0.8.0from
bitdynamics-ab:zheli/delay-devfund-coupon-collection/6722

Conversation

@zheli

@zheli zheli commented Aug 16, 2026

Copy link
Copy Markdown

Implement #6722

@zheli
zheli force-pushed the zheli/delay-devfund-coupon-collection/6722 branch 6 times, most recently from 3af23fe to a566646 Compare August 18, 2026 09:32
@zheli
zheli marked this pull request as ready for review August 18, 2026 09:44

@meiersi-da meiersi-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks a lot!

Comment thread daml/splice-amulet/daml/Splice/AmuletConfig.daml Outdated
Comment thread daml/splice-amulet/daml/Splice/AmuletConfig.daml Outdated
Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml Outdated
Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml Outdated
Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml Outdated
Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml Outdated
Comment thread daml/splice-wallet-test/daml/Splice/Scripts/Wallet/TestMintingDelegation.daml Outdated
Comment thread daml/splice-amulet-test/daml/Splice/Scripts/TestDevelopmentFundCoupon.daml Outdated
@zheli
zheli force-pushed the zheli/delay-devfund-coupon-collection/6722 branch 5 times, most recently from 7fe91ac to 983289f Compare August 19, 2026 11:51

@meiersi-da meiersi-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the good work and quick turnaround time. Two issues remain before we are ready:

  • add release notes (as explained on Slack)
  • address the ExternalPartyConfigState code path concern

Comment thread daml/splice-amulet/daml/Splice/AmuletConfig.daml Outdated
Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml
Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml Outdated
Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml Outdated
Comment thread daml/splice-wallet-test/daml/Splice/Scripts/Wallet/TestMintingDelegation.daml Outdated
@zheli
zheli force-pushed the zheli/delay-devfund-coupon-collection/6722 branch from 983289f to e1b972f Compare August 20, 2026 10:03
@zheli
zheli force-pushed the zheli/delay-devfund-coupon-collection/6722 branch from 081c1c1 to 0d10d57 Compare August 20, 2026 10:46
@zheli
zheli force-pushed the zheli/delay-devfund-coupon-collection/6722 branch from 0d10d57 to 5e02f41 Compare August 20, 2026 10:50
@zheli

zheli commented Aug 20, 2026

Copy link
Copy Markdown
Author

Thanks a lot for the good work and quick turnaround time. Two issues remain before we are ready:

* add release notes (as explained on Slack)

* address the `ExternalPartyConfigState` code path concern

Thanks for your comments @meiersi-da ! Just fixed all the feedback and pushed the change. Could you check them again?

@meiersi-da meiersi-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good work.

@zheli
zheli force-pushed the zheli/delay-devfund-coupon-collection/6722 branch from 5e02f41 to 76ae22a Compare August 20, 2026 14:33
@zheli
zheli deployed to ci-forks August 20, 2026 14:33 — with GitHub Actions Active
…pmentFundMintingDelay in frontend

Signed-off-by: Zhe Li <[email protected]>
@zheli
zheli force-pushed the zheli/delay-devfund-coupon-collection/6722 branch from 27c8455 to 6f73b13 Compare August 20, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants