Skip to content

Enhance MultiSig contract with party details and approvals - #1132

Merged
Jatinp26 merged 14 commits into
canton-network:mainfrom
0xNeshi:patch-3
Aug 19, 2026
Merged

Enhance MultiSig contract with party details and approvals#1132
Jatinp26 merged 14 commits into
canton-network:mainfrom
0xNeshi:patch-3

Conversation

@0xNeshi

@0xNeshi 0xNeshi commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

This is the actual Solidity implementation of the Daml counter-example, thus making it obvious how simpler and more succinct Daml is compared to Solidity.

@shreyas-da
shreyas-da requested review from 8bitpal and Jatinp26 July 30, 2026 09:28
@Jatinp26
Jatinp26 removed the request for review from 8bitpal August 14, 2026 10:27
@Jatinp26

Copy link
Copy Markdown
Collaborator

@0xNeshi wanna close PR, could you please address my above comment?

@0xNeshi

0xNeshi commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Hey @Jatinp26 , I don't see any comments on the PR

@Jatinp26

Copy link
Copy Markdown
Collaborator

@0xNeshi this one, please take a look.
image

0xNeshi and others added 2 commits August 18, 2026 16:32
Renamed contract from MultiSig to Agreement and updated approval logic.
@0xNeshi

0xNeshi commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

re: #1132 (comment)

@Jatinp26 aligned the contract even further:

  • added bool executed flag
  • renamed the contract to Agreement (aligns with the Daml counterpart)
  • ensure execute() can only be called by parties A and B

@Jatinp26

Copy link
Copy Markdown
Collaborator

Thanks @0xNeshi will do a final check then merge

Comment thread docs-main/appdev/modules/m2-canton-for-ethereum-devs.mdx Outdated
@Jatinp26
Jatinp26 merged commit 525cb20 into canton-network:main Aug 19, 2026
3 checks passed
@0xNeshi
0xNeshi deleted the patch-3 branch August 19, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants