feat: support channel syntax in package slices file - #323
Open
upils wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
channelfield to slice definition files, so a single definition can describe content that differs across the channels of a store package. Values are<track>/<risk>patterns where the risk part accepts*(any risk),!<risk>(any but that one) and<risk>,<risk>(only those); a list is a union, and a track may appear at most once. The field is accepted oncontentspaths and onessentialentries, requiresstoreand format v3+, and behaves likearchthroughout: non-matching entries are silently skipped, conflict validation and the manifest ignore it.Motivation: a store holds one bin per channel, but a chisel-release has a single SDF per package, so until now there was no way to say "this path exists only in a given track". Patterns are kept as written and interpreted on each match — the structure
strdistuses for globs — and validated when the release is read, so malformed values fail onReadReleaserather than oncut.Two aspects worth noting for reviewers. First, channels are resolved from each package's
default-trackwith thestablerisk, before dependency ordering, because ordering itself gates channel-specific essentials — a package pulled in only throughessentialmust already know its channel. Second, without CLI channel selection (follow-up PR) the resolved channel is constant per package, so the field is currently dormant: the grammar, validation and filtering machinery are in place and exercised by tests, andSelection.Channelsis ready for the CLI and store-fetch work to activate.