feat(admin): add authenticated settings API endpoints#690
Open
Ferryx349 wants to merge 5 commits into
Open
Conversation
Signed-off-by: ABHAY PANDEY <[email protected]>
Signed-off-by: ABHAY PANDEY <[email protected]>
Signed-off-by: ABHAY PANDEY <[email protected]>
🦋 Changeset detectedLatest commit: cc5c7b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| router.get('/session', adminRateLimitMiddleware, adminAuthMiddleware, withAdminController(createGetAdminSessionController)) | ||
| router.get('/health', adminRateLimitMiddleware, adminAuthMiddleware, withAdminController(createGetAdminHealthController)) | ||
| router.get('/metrics', adminRateLimitMiddleware, adminAuthMiddleware, withAdminController(createGetAdminMetricsController)) | ||
| router.get('/settings', adminRateLimitMiddleware, adminAuthMiddleware, withAdminController(createGetAdminSettingsController)) |
| router.get( | ||
| '/settings/schema', | ||
| adminRateLimitMiddleware, | ||
| adminAuthMiddleware, |
| adminAuthMiddleware, | ||
| withAdminController(createGetAdminSettingsSchemaController), | ||
| ) | ||
| router.patch('/settings', adminRateLimitMiddleware, adminAuthMiddleware, json(), withAdminController(createPatchAdminSettingsController)) |
| router.post( | ||
| '/settings/validate', | ||
| adminRateLimitMiddleware, | ||
| adminAuthMiddleware, |
Collaborator
|
Coverage is 68.718% — Ferryx349:settings-api into cameri:main. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds backend-only admin settings endpoints that reuse the shared settings-config module from #672, so the admin console can read and update relay settings without duplicating CLI logic.
Why
The admin settings editor needs the same get/set/validate behavior as the CLI. This PR exposes that through authenticated admin routes ahead of the UI work in #594.
Related Issue
Fixes- Part of #665
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: