Skip to content

Fix 5.next migration dispatch analysis and snapshot expectation #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 1 commit into from
Oct 8, 2026
Merged

Fix 5.next migration dispatch analysis and snapshot expectation #1120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Migration/Environment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ public function executeMigration(MigrationInterface $migration, string $directio
// (statically narrowable for IDEs and static analysis), then a
// method_exists fallback for migrations that haven't yet adopted
// either ReversibleMigrationInterface or DirectionalMigrationInterface.
$isReversible = $migration instanceof ReversibleMigrationInterface
if (
$migration instanceof ReversibleMigrationInterface
|| (!$migration instanceof DirectionalMigrationInterface
&& method_exists($migration, MigrationInterface::CHANGE));

if ($isReversible) {
&& method_exists($migration, MigrationInterface::CHANGE))
) {
if ($direction === MigrationInterface::DOWN) {
// Create an instance of the RecordingAdapter so we can record all
// of the migration commands for reverse playback
Expand Down
3 changes: 2 additions & 1 deletion tests/comparisons/Migration/test_snapshot_with_on_update.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
declare(strict_types=1);

use Migrations\BaseMigration;
use Migrations\DirectionalMigrationInterface;

class TestSnapshotWithOnUpdate extends BaseMigration
class TestSnapshotWithOnUpdate extends BaseMigration implements DirectionalMigrationInterface
{
/**
* Up Method.
Expand Down
Loading