Repository navigation
fix: re-register 16 dropped evals; review-rigor follow-ups - #203
Merged
Merged
Conversation
- implement-gate: every tests/*.test.sh must be registered (16 are not; ci-checks runs only this aggregator, so they never gate a build) - reviewer prompts label plugin-internal FR/ADR citations - /tdd-author 7b dispatches design-reviewer by prompt file - /prd-author self-review stops routing TBD tokens into Open questions - tdd-lint resolves its lib dir once Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NpGG21Y2VGGhTQaFr4oshB
- implement-gate re-registers the 16 evals dropped with the coprocess runner (TDD 0063) and adds a [registry] check so the list stays complete; CONTRIBUTING documents the rule - design/build/requirements reviewer prompts label their FR/ADR citations as the plugin's own design records, not the reviewed repo's - /tdd-author 7b dispatches design-reviewer by prompt file, not agent type - /prd-author self-review: move an open item to Open questions without the TBD/TODO token (prd-lint flags it on any new line) - tdd-lint resolves its lib dir once (_TL_LINT_LIB_ABS folded in) Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NpGG21Y2VGGhTQaFr4oshB
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NpGG21Y2VGGhTQaFr4oshB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the review-rigor build (#200–#202), plus a gate gap found while fixing them. Plugin 3.57.0 → 3.57.1.
The gate gap: 16 evals never ran
scripts/ci-checks.shruns onlytests/implement-gate.test.sh, and the aggregator's eval list lost 16 evals when the coprocess runner was retired (TDD 0063, Aug 2026). Since then, bounded-tdd-scope, md-parser, token-spend-reduction, evaluation-rubric, markers, interactive-draft-persistence and ten others never gated a build. All 16 pass today.REGISTERED_EVALS.[registry]check fails the aggregator when anytests/*.test.shis missing from the list. As a negative control, a probe eval left off the list makes the aggregator exit 1 and name it.CONTRIBUTING.mddocuments the rule.Review-rigor follow-ups
/tdd-authorstep 7b dispatches the design reviewer by its prompt file ($(tl_plugin_root)/agents/design-reviewer.md), not by agent-type name. This matches the build-reviewer dispatch. The model-roles fresh-worker wording is unchanged./prd-authorself-review told authors to "move it to Open questions". But prd-lint flags TBD/TODO on any new line, Open questions included. The bullet now says to move the item as a plain question, without the token. This is 0073 review N3.tdd-lint.shresolved its lib directory twice (_TL_LINT_LIBand_TL_LINT_LIB_ABS). Now it resolves it once, and both theux.shandverdicts.shsourcing use it. This is 0074 review N1.Verification
Each fix was test-first: a
test(failing)commit, then the fix.scripts/ci-checks.shexits 0, with all 34 evals registered and run.🤖 Generated with Claude Code
https://claude.ai/code/session_01NpGG21Y2VGGhTQaFr4oshB