Repository navigation
TDD 0071: /ux-author skill + ux-reviewer critique agent - #196
Merged
Merged
Conversation
…1/FR-86 scans tests/ux-author-skill.test.sh extracts tl:ux-preflight / ux-validate / ux-render from skills/ux-author/SKILL.md and runs them under env -i in temp repos (obs 1-3, 3b, 6-9). parent-session-check NAMES and plugin-root [K] gain ux-author. Red: the skill and agent do not exist yet. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NpGG21Y2VGGhTQaFr4oshB
skills/ux-author/SKILL.md: steps 0-11 with the byte-identical tl:fr86-check block and the tl:ux-preflight / ux-validate / ux-render blocks over scripts/lib/ux.sh (TDD 0070). Interrogator and rubric rules are read from /prd-author by reference; mocks are delegated by role with an honest degrade. agents/ux-reviewer.md: fresh-worker critique, model inherit, validate first, report-file last line UX_REVIEW: PASS|BLOCK. README gains a /ux-author Workflow subsection; plugin.json description names the phase. The eval's no-browser PATH also links base64 (the stub browser needs it). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NpGG21Y2VGGhTQaFr4oshB
ci-checks runs only the aggregator, so an unregistered eval never gates. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NpGG21Y2VGGhTQaFr4oshB
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NpGG21Y2VGGhTQaFr4oshB
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NpGG21Y2VGGhTQaFr4oshB
Base automatically changed from
build/20261006-220142/0070-ux-record-lib
to
master
October 8, 2026 00:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements TDD 0071: the
/ux-authorskill and its independentux-reviewercritique agent (PRD FR-90–FR-100, FR-22, FR-79, FR-81, FR-86, FR-87, NFR-1, NFR-3; ADR 0017). Plugin 3.52.0 → 3.53.0.What it adds
skills/ux-author/SKILL.md(steps 0–11):tl:fr86-checkblock is byte-identical to the other skills');tl:ux-preflight, which runs the merged-PRD check and the delta, prints the no-UI line, then shows a draft screen plan first;/prd-author's rules by reference;tokens.css, derive it from code, or establish it with an ADR;tl:ux-validateandtl:ux-rendergiven explicit screen ids;docs/ux/<slug>PR (never merged) whose body lists assumptions, the critique, delegates and fidelity, requirement gaps, approved screen sets and screenshots.agents/ux-reviewer.md: validates first, computes unmapped[UI]ids withtl_ux_delta, treatsdelegatesas self-reported, writes its report to the dispatched path, and endsUX_REVIEW: PASS|BLOCK./ux-authorsubsection;plugin.jsondescription.ux-authoris added to the FR-81 harness-language scan and the FR-86 parent-check eval.Gates
test(failing)19c1b88 precedesfeatef85e7e/ux-authorrun in a scratch repo (degraded, no-delegate path, skip-git): real-Chrome render 6/6,index.jsonwithdelegates: []andfidelity: mid, design-system ADR +tokens.css, all PR-body sections, PRD unchanged. Its critique was dispatched by the parent and returnedUX_REVIEW: PASS. obs 12: the critique on a fixture with no screen for FR-2 returnedUX_REVIEW: BLOCK unmapped — FR-2Deviations (accepted in review)
tests/implement-gate.test.shregisters the new eval, andreleases.jsongets the 3.53.0 entry. Both files are outside the declared Touched files._tl_integration_reffromverdicts.sh, which has no public wrapper.PATHgainedbase64after thetest(failing)commit. No assertion changed.Non-blocking follow-ups (candidate gap-closure)
index.jsonfield values: fidelity, baseline strings, state shapes,flow, and the repo-relativeadr. Validate already rejects invalid values; this fixes semantic mislabels.tl_ux_integration_refwrapper (fixes A1 and the underscore call).<url>in thetl_ux_capturetemplate.gh pr create --body-file, since it embeds untrusted text./tdd-authorhas the same gap.ux-reviewernits: it must run from the repo root, and it has no Write tool, so it writes the report through Bash.🤖 Generated with Claude Code
https://claude.ai/code/session_01NpGG21Y2VGGhTQaFr4oshB