Repository navigation
design: TDDs 0064–0065 + ADR 0014 (model capability by job) - #179
Merged
Merged
Conversation
PRD-rev 5dbf968. 0064 supersedes 0057: unset review= equals build=; design-reviewer inherits; FR-87 parent warning. 0065 is FR-86: session artifact + this-turn official-docs fetch; no static rank map. Open assumptions & waivers: - session-model observation — resolved: session artifact (Grok summary.json current_model_id; Claude jsonl last non-synthetic message.model). Missing env/file/field = unreadable → warn+ask. - weaker/newer comparator — resolved: no static rank map. Compare is a this-turn official-docs fetch. Recency-only is forbidden. Fetch/judge fail is unreadable → warn+ask. - live catalog source and ranking — resolved: fetch Anthropic models overview + Claude Code model-config, or xAI models/flagship. Bar is live vendor top-tier and may be newer than the models.sh binding. - lookup failure / no key / offline — resolved: cannot fetch or cannot judge → unreadable → warn+ask. Evals do not hit the network. - design-reviewer frontmatter pin — resolved: inherit; no model: sonnet. Independence is a fresh worker. - FR-87 warning visibility — resolved: parent prints THROUGHLINE_*_MODEL=<id> differs from the most-capable default; continuing. Mechanical verify pin does not warn. - one binding site — resolved: models.sh is the only dispatch binding. FR-86 does not copy ids. - ADR 0009 conflict — resolved: ADR 0014 supersedes 0009.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design
PRD-rev
5dbf968(PR #178). Two draft TDDs + one ADR.review=equalsbuild=when unset. Design-reviewermodel: inherit. FR-87 parent warning uses “differs from,” not “below.”Do not merge until you have reviewed the design. Merge is the design gate that makes these TDDs buildable (
/build-tdds).Design-critique verdict
Independent
design-reviewer(fresh worker): DESIGN_REVIEW: PASS.Rubric: co-created with the user (
## Evaluation rubricidentical in both TDDs). Gate graded against that table. No failing row. 0064 high-quality on traceability, interfaces, verification, scope, naming, no-rank-map; alternatives acceptable (the HQ live-fetch pair lives in 0065). 0065 high-quality on alternatives / no-rank-map / verification; interface concreteness acceptable (page-grounded judge is not mechanical).Findings (none blocking; folded where cheap before this PR):
$PWDfirst, git-root fallback (folded).<synthetic>asmessage.model(folded)..→-; Grok encode example%2F…(folded).Open assumptions & waivers
summary.jsoncurrent_model_id; Claude jsonl last non-syntheticmessage.model). Missing env/file/field = unreadable → warn+ask.models.shbinding.model: sonnet. Independence is a fresh worker.THROUGHLINE_*_MODEL=<id> differs from the most-capable default; continuing. Mechanical verify pin does not warn.models.shis the only dispatch binding. FR-86 does not copy ids.