Repository navigation
build: TDD 0060 harness-agnostic skills + Grok marketplace - #172
Merged
Merged
Conversation
Pins tl_plugin_root / tl_plugin_data fail-closed + precedence before the helper exists. Red because scripts/lib/plugin-root.sh is absent. TDD: 0060
Fail-closed resolver: first existing CLAUDE_PLUGIN_ROOT or GROK_PLUGIN_ROOT; first set CLAUDE_PLUGIN_DATA or GROK_PLUGIN_DATA (exports THROUGHLINE_PLUGIN_DATA). No path probing, no git lookup. TDD: 0060
Authoring/status skills still name AskUserQuestion and hard-code CLAUDE_PLUGIN_ROOT; .grok-plugin/marketplace.json is absent. TDD: 0060
Replace vendor tool names with actions; resolve the plugin tree via tl_plugin_root. Add .grok-plugin/marketplace.json. Retarget the 0014 refusal-flow eval to the new question wording so ci-checks stay green. TDD: 0060
Four FR-15 observations held: test(failing): precedes feat; ci-checks PASS; verification plan observations PASS; independent review PASS. build-engine: bootstrap records the FR-84 exception used for this flip. TDD: 0060
Functional skills/scripts change; version-bump-check requires a minor bump. Build-applied housekeeping, same as prior implement PRs. TDD: 0060
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bootstrap build of TDD 0060 (FR-84:
/build-tddsdoes not exist until 0062 lands). Addstl_plugin_root/tl_plugin_data, rewrites authoring/status skills to action language, and ships.grok-plugin/marketplace.json.FR-15 observations
89574f1 test(failing): plugin-root env resolver; second red slice37ee7adbefore skill/marketplace featCI_CHECKS_TEST_CMD=bash tests/implement-gate.test.sh→ PASSCLAUDE_PLUGIN_ROOT=$PWD→ prints$PWDrc 0;rgof the five skills forAskUserQuestion|claude -p|grok -pexits 1;jq -e '.plugins[0].name=="throughline"'succeeds.plugin-root.test.sh27/0.grok plugin validate .accepts the layoutdocs/tdd/.implement-logs/bootstrap-0060/review.md(gitignored)Human merge remains the gate (FR-16). Do not auto-merge.
Scope note (reviewer minor)
Declared Touched files listed
skills/adr-new/SKILL.md(already clean; zero diff) and nottests/bounded-tdd-scope.test.sh. The 0014 eval still required the literalAskUserQuestionstring; that one assertion was retargeted tostructured multiple-choice questionso FR-81 does not turn the old eval red. Still 8 files. Reviewer judged this a justified CI-coherence exception, not a structural-finding.adr-newwas already vendor-name-free; it stays in the FR-81 scan.Open assumptions & waivers
Bootstrap exception (FR-84) used for this TDD. After merge, next is 0061 the same way until
/build-tddscan flip.