Skip to content

Update codegen - #240

Open
MendyBerger wants to merge 4 commits into
bytecodealliance:mainfrom
MendyBerger:update-codegen
Open

Update codegen#240
MendyBerger wants to merge 4 commits into
bytecodealliance:mainfrom
MendyBerger:update-codegen

Conversation

@MendyBerger

@MendyBerger MendyBerger commented Aug 28, 2026

Copy link
Copy Markdown

Resolves #218

Implemented according to what was agreed upon in the following comments:


Since this is quite a lot of code, I've split it into 3 commits:

  • Codegen code changes
  • Existing tests updates
  • New tests

@dicej dicej left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this (and for the excellent test coverage), @MendyBerger!

Looks good to me; my only concern is the remove_dir_all added to BindingsGenerator::generate, which could be a surprising change from the previous behavior. I'd prefer to avoid that and instead simply refuse to generate the bindings by default if the directory already exists (in which case the user can remove it themself), with an option to force the existing directory to be used if desired.

Comment thread src/lib.rs Outdated
Comment thread src/test/tests.rs Outdated
@MendyBerger
MendyBerger requested a review from dicej August 30, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: change how generated modules are named and nested by default

2 participants