Repository navigation
fix(config): preserve saved list values - #366
Merged
Merged
Conversation
bw2
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Saving
['a,b', 'c']with the default config parser currently writes[a,b, c], which reads back as three entries. JSON-looking strings, empty entries, surrounding whitespace, and nested lists can also change when saved.Write list values using the JSON syntax the parser already accepts. Scalar formatting and the existing rejection of literal newlines remain unchanged; saved string lists now contain quotes. The round-trip regression covers commas, padding, empty strings, quotes, backslashes, numeric/boolean-looking strings, and nested lists. Existing exact-output tests are updated for JSON quoting.
Testing
On Python 3.13, the full suite passes: 2,026 passed, one skipped, five expected failures. Black, the repository's warnings-as-errors Pydoctor documentation check, and source/wheel builds pass. Codex assisted with this fix and its tests.
Breaking Changes
Saved list values now use JSON quoting. The parser already accepts that syntax; scalar formatting and literal-newline rejection are preserved.
Manual verification: Serialize {'files': ['a,b', 'c']} with the default parser and parse it again; the list should retain exactly two original elements.