Ignore zizmor self-repository audit in CI - #66
Merged
Merged
Conversation
zizmor 1.30.0 added a `self-repository` audit that flags the five workspace-relative `uses: ./.github/workflows/*.yml` calls in `cargo.yml` and asks for GitHub's new `uses: $/...` syntax. actionlint 1.7.12 rejects the `$/` form with a `workflow-call` format error, so switching would trade one failing hook for another. Keep the `./` form and add inline `zizmor: ignore[self-repository]` comments, matching the existing `ref-version-mismatch` suppressions. Drop the ignores once actionlint accepts `$/`. Ave Deus Mechanicus
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zizmor 1.30.0 added the
self-repositoryaudit, which failed the lint job in run 36166326608. It flags the fiveuses: ./.github/workflows/*.ymlcalls incargo.ymland wants GitHub's newuses: $/...syntax.actionlint 1.7.12 doesn't accept
$/yet. It reports aworkflow-callformat error on every call, so switching syntax would just move the failure to a different hook.Change
# zizmor: ignore[self-repository]to each reusable workflow call in.github/workflows/cargo.yml. This follows the existingref-version-mismatchignores.jobs:saying why.Remove the ignores once actionlint accepts
$/.Testing
zizmorover all workflows: no findings (5 ignored).actionlint .github/workflows/cargo.yml: passes.$/form against actionlint 1.7.12 on a scratch copy of the workflows. All five calls fail.Summary by CodeRabbit