Upgrade to TypeScript 6.0 - #191
Open
ajeetdsouza wants to merge 4 commits into
Open
ajeetdsouza wants to merge 4 commits into
ajeetdsouza wants to merge 4 commits into
Conversation
Signed-off-by: Ajeet D'Souza <[email protected]>
timostamm
reviewed
Sep 21, 2026
Signed-off-by: Ajeet D'Souza <[email protected]>
Signed-off-by: Ajeet D'Souza <[email protected]>
timostamm
reviewed
Sep 21, 2026
| "prebuild": "rm -rf ./dist/*", | ||
| "build": "npm run build:cjs && npm run build:esm", | ||
| "build:cjs": "tsc --project tsconfig.json --module commonjs --verbatimModuleSyntax false --moduleResolution node10 --outDir ./dist/cjs && echo >./dist/cjs/package.json '{\"type\":\"commonjs\"}'", | ||
| "build:cjs": "tsc --project tsconfig.json --module commonjs --verbatimModuleSyntax false --moduleResolution node10 --ignoreDeprecations 6.0 --outDir ./dist/cjs && echo >./dist/cjs/package.json '{\"type\":\"commonjs\"}'", |
Member
There was a problem hiding this comment.
Ignoring the deprecation via a flag looks good to me. In protobuf-es, connect-es, and connectrpc/connect-playwright-es#207 we're setting the tsconfig option instead. In connectrpc/connect-query-es#605, we're using both. Can we make this consistent? Will make reviews and future changes much easier.
Contributor
Author
There was a problem hiding this comment.
That's deliberate - in connectrpc/connect-playwright-es#207 and connectrpc/connect-query-es#605, when we set ignoreDeprecations, the tsconfig itself uses moduleResolution=Node10. I figured we could upgrade the moduleResolution in a separate PR since it's not related to TS 6.0, but if we want a consistent set of PRs, I can make that change in this PR itself.
Signed-off-by: Ajeet D'Souza <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed
"esModuleInterop": false- it is deprecated in TypeScript 6.0, and removed in 7.0.