Skip to content

feat(registry)!: adopt new Remix APIs across presets - #360

Draft
leoafarias wants to merge 1 commit into
stack/follow-ups-integrationfrom
feat/preset-adoption
Draft

leoafarias wants to merge 1 commit into
stack/follow-ups-integrationfrom
feat/preset-adoption

Conversation

@leoafarias

@leoafarias leoafarias commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Draft: Vanilla, HeroUI, and Fortal adopt the new Remix APIs together. Ship this after Remix 1.0.0-beta.14 and naked_ui 1.3.0 are published and the runtime/registry floors have advanced.

Changes by theme

  • Preset styling: move focus rings to containerEffects/triggerEffects, keep layout stable, use anchor-width sizing, and adopt styled radio/switch labels and toast action placement.
  • Real controls: use caller-owned menu/popover buttons in dashboard and installed-gallery examples, preserving a single focus stop, expanded semantics, and focus return.
  • Distribution: regenerate preset templates/adapters and synchronize the installed app copies, worksheets, parity evidence, and component documentation.
  • Audit regression: correct the HeroUI popover fixture comment and explicitly assert expanded state before opening, while open, and after closing.

Where to look

  • Real code: registry_source/lib/src/{default,heroui,fortal}/components/, their theme/effects helpers, dashboard recipes, and installed source under apps/.
  • Runtime/fixture tests: registry_source/test/{vanilla,heroui,fortal,dashboard}/, shared pixel helpers, and open_code/{fixture,heroui_fixture}/test/. The expanded-state regression is in open_code/heroui_fixture/test/open_code_test.dart.
  • Generated files: registry/{vanilla,heroui,fortal}/templates/, generated *.g.dart adapters, and the parity manifest. Human-maintained documentation lives in registry_source/specs/, ADRs, docs/, and skills/.

Base and verification

Temporary review base: stack/follow-ups-integration (#339), pinned at d5990f4d2877a05ba63ff7cf1cdc9fbd4f220c1d. All three source drafts already use this base, which supplies the required runtime APIs and HeroUI foundation. This keeps the diff limited to adoption instead of including P2–P7 prerequisites. Retarget to main after the consolidated runtime PRs, HeroUI foundation, and beta.14 release land. #339 remains open for Leo's decision.

One squashed adoption commit. Independent reconstruction matches all three source deltas plus the listed audit fix (13f70504f9a76b3f76b2e51cb0030121be0d20f1). Both Vanilla and Fortal dashboard regression groups are retained, with the unrestricted services import. Local validation on Flutter 3.44.0 passes: the affected preset authoring regressions, formatting, generated registry drift, and melos run ci:checks. A fresh CLI-installed HeroUI consumer passes all 19 tests and analysis. Runtime revert proof: baseline passes; removing only expanded: state.isOpen from production RemixPopover fails the fixture assertion with “missing flags: hasExpandedState”; restoring that production line passes again. There is no compilation failure in the reverted run, and the production tree is restored and clean.

Replaces #342, #343, and #346.

Final CI: 12 latest checks pass on 9a4599a2213c023c97075789f291c56c655fa845; 1 deployment check is skipped by its workflow condition.

Fix-round note: this draft still requires retargeting off #339’s stack/follow-ups-integration branch after the consolidated prerequisites land. It ships after beta.14.


Open workspace in Conductor

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant