Repository navigation
feat(registry)!: adopt new Remix APIs across presets - #360
Draft
leoafarias wants to merge 1 commit into
Draft
leoafarias wants to merge 1 commit into
leoafarias wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: Vanilla, HeroUI, and Fortal adopt the new Remix APIs together. Ship this after Remix 1.0.0-beta.14 and naked_ui 1.3.0 are published and the runtime/registry floors have advanced.
Changes by theme
containerEffects/triggerEffects, keep layout stable, use anchor-width sizing, and adopt styled radio/switch labels and toast action placement.Where to look
registry_source/lib/src/{default,heroui,fortal}/components/, their theme/effects helpers, dashboard recipes, and installed source underapps/.registry_source/test/{vanilla,heroui,fortal,dashboard}/, shared pixel helpers, andopen_code/{fixture,heroui_fixture}/test/. The expanded-state regression is inopen_code/heroui_fixture/test/open_code_test.dart.registry/{vanilla,heroui,fortal}/templates/, generated*.g.dartadapters, and the parity manifest. Human-maintained documentation lives inregistry_source/specs/, ADRs,docs/, andskills/.Base and verification
Temporary review base:
stack/follow-ups-integration(#339), pinned atd5990f4d2877a05ba63ff7cf1cdc9fbd4f220c1d. All three source drafts already use this base, which supplies the required runtime APIs and HeroUI foundation. This keeps the diff limited to adoption instead of including P2–P7 prerequisites. Retarget to main after the consolidated runtime PRs, HeroUI foundation, and beta.14 release land. #339 remains open for Leo's decision.One squashed adoption commit. Independent reconstruction matches all three source deltas plus the listed audit fix (
13f70504f9a76b3f76b2e51cb0030121be0d20f1). Both Vanilla and Fortal dashboard regression groups are retained, with the unrestricted services import. Local validation on Flutter 3.44.0 passes: the affected preset authoring regressions, formatting, generated registry drift, andmelos run ci:checks. A fresh CLI-installed HeroUI consumer passes all 19 tests and analysis. Runtime revert proof: baseline passes; removing onlyexpanded: state.isOpenfrom productionRemixPopoverfails the fixture assertion with “missing flags: hasExpandedState”; restoring that production line passes again. There is no compilation failure in the reverted run, and the production tree is restored and clean.Replaces #342, #343, and #346.
Final CI: 12 latest checks pass on
9a4599a2213c023c97075789f291c56c655fa845; 1 deployment check is skipped by its workflow condition.Fix-round note: this draft still requires retargeting off #339’s
stack/follow-ups-integrationbranch after the consolidated prerequisites land. It ships after beta.14.Open workspace in Conductor