Skip to content

fix(remix): consolidate behavior fixes - #356

Merged
leoafarias merged 7 commits into
mainfrom
fix/remix-behavior-fixes
Oct 30, 2026
Merged

leoafarias merged 7 commits into
mainfrom
fix/remix-behavior-fixes

Conversation

@leoafarias

@leoafarias leoafarias commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Fix Remix motion, rebuild subscriptions, and widget-state isolation together, while preserving the existing component APIs except for the additive reduced-motion builder.

Changes by theme

  • Accessibility motion: honor both platform reduce-motion and MediaQuery disableAnimations in accordion, select, sidebar, and skeleton, including transitions already in progress. Essential spinner motion remains unchanged.
  • Rebuilds: subscribe only to the MediaQuery values used by the sidebar and functional glyphs.
  • State isolation: prevent ancestor/trigger widget state from leaking into non-sortable table headers, accordion/disclosure content, and sidebar header/footer content.

Where to look

  • Real code: packages/remix/lib/src/utilities/remix_reduced_motion.dart, the accordion/select/sidebar/skeleton widgets, data-table header rendering, and registry_source/lib/src/agent/support/functional_glyph.dart plus its installed app copies.
  • Tests: reduced-motion component and utility suites, sidebar collapse regressions, data-table/header and panel state tests, and registry_source/test/agent/components/loading_test.dart.
  • Documentation: component MDX pages, the styling guide/skill, and packages/remix/CHANGELOG.md. No generated API adapters change.

Verification and integration

One behavior commit based on #355 (feat/remix-public-api-additions). After #355 is squash-merged, rebase this owning behavior commit onto updated main, excluding the original #355 parent, then retarget. This repository permits squash merges only: retargeting alone would restore the three confirmed text conflicts. The source delta remains #323, #327, and #340, with the approved three-file integration resolution.

The accordion retains P2's custom-trigger effect wrapper and P3's empty content-state scope. The sidebar retains both effects and reduced-motion imports. Every source changelog entry remains. The saved resolution was adapted to the corrected P2 changelog. An isolated simulation of P2 → P5 landing as new squash commits rebases every owning commit without conflicts and preserves its exact patch and full tree. The independent temporary-index reconstruction reaches the same cumulative tree. No source refs or remotes changed during the simulation.

Expected and actual full trees match: 02c0c25d44aa7230fa6d6b09fcdfb1d5940cf401.

Local validation on Flutter 3.44.0 passes: 3,076 Remix tests and melos run ci:checks (including analysis and documentation/contracts). Latest CI on 8634bc13a326da3e83598f13a1bf1ea345c7d6db: 15 checks pass; 1 deployment check is skipped by its workflow condition.

Replaces #323, #327, #340.


Open workspace in Conductor

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T20:28:29.580312Z 4f1f5a0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Resolve the public API integration before the behavior changes: retain trigger effects, isolate content state, preserve both sidebar imports, and combine every source changelog entry.
@leoafarias
leoafarias force-pushed the fix/remix-behavior-fixes branch from 38f3334 to 8634bc1 Compare October 30, 2026 02:09
@leoafarias
leoafarias changed the base branch from main to feat/remix-public-api-additions October 30, 2026 02:09
Base automatically changed from feat/remix-public-api-additions to main October 30, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant