Repository navigation
fix(remix): consolidate behavior fixes - #356
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Resolve the public API integration before the behavior changes: retain trigger effects, isolate content state, preserve both sidebar imports, and combine every source changelog entry.
leoafarias
force-pushed
the
fix/remix-behavior-fixes
branch
from
October 30, 2026 02:09
38f3334 to
8634bc1
Compare
leoafarias
changed the base branch from
main
to
feat/remix-public-api-additions
October 30, 2026 02:09
This was referenced Oct 30, 2026
Update the Select ring test to focus the second option after opening, since Naked UI 1.3.0 now focuses the first option automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Remix motion, rebuild subscriptions, and widget-state isolation together, while preserving the existing component APIs except for the additive reduced-motion builder.
Changes by theme
Where to look
packages/remix/lib/src/utilities/remix_reduced_motion.dart, the accordion/select/sidebar/skeleton widgets, data-table header rendering, andregistry_source/lib/src/agent/support/functional_glyph.dartplus its installed app copies.registry_source/test/agent/components/loading_test.dart.packages/remix/CHANGELOG.md. No generated API adapters change.Verification and integration
One behavior commit based on #355 (
feat/remix-public-api-additions). After #355 is squash-merged, rebase this owning behavior commit onto updated main, excluding the original #355 parent, then retarget. This repository permits squash merges only: retargeting alone would restore the three confirmed text conflicts. The source delta remains #323, #327, and #340, with the approved three-file integration resolution.The accordion retains P2's custom-trigger effect wrapper and P3's empty content-state scope. The sidebar retains both effects and reduced-motion imports. Every source changelog entry remains. The saved resolution was adapted to the corrected P2 changelog. An isolated simulation of P2 → P5 landing as new squash commits rebases every owning commit without conflicts and preserves its exact patch and full tree. The independent temporary-index reconstruction reaches the same cumulative tree. No source refs or remotes changed during the simulation.
Expected and actual full trees match:
02c0c25d44aa7230fa6d6b09fcdfb1d5940cf401.Local validation on Flutter 3.44.0 passes: 3,076 Remix tests and
melos run ci:checks(including analysis and documentation/contracts). Latest CI on8634bc13a326da3e83598f13a1bf1ea345c7d6db: 15 checks pass; 1 deployment check is skipped by its workflow condition.Replaces #323, #327, #340.
Open workspace in Conductor