Repository navigation
feat(icons): add the unified Vector UI icon pack - #336
Draft
leoafarias wants to merge 3 commits into
Draft
leoafarias wants to merge 3 commits into
leoafarias wants to merge 3 commits into
Conversation
| if (typeof path !== 'string') throw new RangeError(`Unavailable drawing: ${name}/${appearance}/${master}`); | ||
| if (title !== null && (typeof title !== 'string' || !title.trim())) throw new TypeError('title must be a nonempty string or null'); | ||
| const semantics = title === null ? 'aria-hidden="true"' : `role="img" aria-label="${escapeXML(title)}"`; | ||
| return `<svg xmlns="http://www.w3.org/2000/svg" width="${size}" height="${size}" viewBox="0 0 ${master} ${master}" fill="currentColor" fill-rule="evenodd" focusable="false" ${semantics}>${title === null ? '' : `<title>${escapeXML(title)}</title>`}<path d="${path}"/></svg>`; |
| if (typeof path !== 'string') throw new RangeError(`Unavailable drawing: ${name}/${appearance}/${master}`); | ||
| if (title !== null && (typeof title !== 'string' || !title.trim())) throw new TypeError('title must be a nonempty string or null'); | ||
| const semantics = title === null ? 'aria-hidden="true"' : `role="img" aria-label="${escapeXML(title)}"`; | ||
| return `<svg xmlns="http://www.w3.org/2000/svg" width="${size}" height="${size}" viewBox="0 0 ${master} ${master}" fill="currentColor" fill-rule="evenodd" focusable="false" ${semantics}>${title === null ? '' : `<title>${escapeXML(title)}</title>`}<path d="${path}"/></svg>`; |
leoafarias
force-pushed
the
conductor/vector-ui-unified-icon-families
branch
from
October 29, 2026 21:28
186f8c0 to
8585398
Compare
Land Angular, Soft, and Technical as sibling families in one private package, with a single build, check suite, and comparison catalog. Co-authored-by: Cursor <[email protected]>
leoafarias
force-pushed
the
conductor/vector-ui-unified-icon-families
branch
from
October 29, 2026 21:38
8585398 to
43e909d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
design/icons/in one private pack ("private": true, BSD 3-Clause, copyright Leo Farias). This replaces the closed stacked pilots (feat(icons): add Angular icon-family pilot #244, feat(icons): add Soft icon pack pilot #254, feat(icons): add Technical icon pack pilot #253) with a single draft. It does not touchpackages/remix_ui_iconsorregistry/icons.yaml.design/icons/build.py) runs each family's own constructor, then writesdesign/icons/catalog/index.html, which compares Angular, Soft, and Technical. Soft and Technical stay on their own primitives.Test plan
python build.pyfromdesign/iconson CPython 3.13. Family rebuilds match the recovered SVG bytes (Angular 288, Soft 72, Technical 72).python tools/run_checks.py: pack tests, Angular asset/node/rebuild/pixel suite, Soft (19), Technical (28).design/icons/catalog/index.htmland read a row across Angular, Soft, and Technical, including every Warning cell. Dark surface toggle and a 390px viewport keep the three families on one row.Made with Cursor
Open workspace in Conductor