[leoafarias]

Test-suite cleanup only (packages/noir/test). No lib/ changes.

−593 / +124

Removed

• tui_app_event_loop_test.dart input-dispatch scan. Covered by input_dispatcher_ownership_test.dart “TuiBinding schedules frames through InputDispatcher”, and by a new file-wide scheduleMicrotask ban on tui_binding.dart in scheduler_ownership_test.dart “TuiBinding owns frame scheduling integration”. app.dart was already banned in “TuiApp no longer owns frame timing or coalescing”.
• Event-loop layout/paint scan. Covered by pipeline_ownership_test.dart “TuiBinding delegates layout and paint to PipelineOwner” and render_view_ownership_test.dart “binding and test harness use RenderView instead of descendant root lookup”.
• Event-loop key/rebuild. Covered by tui_binding_integration_test.dart “runTuiApp integration harness drives parser to dispatcher handler”.
• Event-loop caller-owned renderer. Covered by tui_binding_test.dart “headless injected renderer remains caller-owned through binding dispose”.
• low_level_symbol_monotonic_test.dart and baselines/noir_low_level_symbols.txt. Covered by internals_barrel_split_test.dart _lowLevelAllowlist (added, removed, moved, or missing show). The three barrel scans still read lib/noir_low_level.dart directly.
• native_lifecycle_test.dart render-object handle scan. It matched no file. The live owners stay locked by “core native resource owners expose deterministic dispose paths”, “renderer finalizer swallows destroy failures”, and “Renderer owns one disposed guard for both raw capabilities”.
• input_semantics_ownership_test.dart InputDispatcher semantic ban. Covered by input_dispatcher_ownership_test.dart “InputDispatcher does not own semantic input routing”.
• Companion hook-family and signal-family subset lists. Covered by “the companion barrel exports nothing but the approved surface”.
• tui_app_exit_test.dart rendererless enableMouse. Covered by tui_app_startup_test.dart “rendererless mouse options fail before mounting the widget”.
• tui_binding_test.dart double dispose. Covered by tui_app_facade_test.dart “runTuiApp mounts once and TuiApp dispose unmounts once”.
• text_input_obscure_test.dart returnsNormally for * and •. Covered by “paints obscuringCharacter ("*") for each grapheme in the value” and “custom obscuringCharacter is honoured at paint time”.
• animation_controller_sanity_test.dart zero-distance forward(). Covered by animation_controller_run_state_test.dart “forward() already at upperBound completes with no ticking”, which now also expects value == 1.0.
• driver_test.dart fresh _CustomHitTarget isA expects. Covered by the same test’s click parity, “locator clicks a custom HitTestTarget on the same cell as dispatch”.
• geometry_constraints_test.dart expect(Size.zero, Size.zero). Covered by the isNormalized expects in “valid bounded, unbounded, and zero constraints stay normalized”.
• container_widget_test.dart alignment tests and the lone Text('Hello'). Covered by align_offset_test.dart “center positions a natural child within tight bounds”, text_widget_golden_test.dart “all text widget variations” (container_centered), widget_golden_test.dart “alignment combinations”, and buffer_capture_test.dart “simple text rendering matches expected output”.
• layout_widgets_test.dart textAlign size check. Covered by text_widget_golden_test.dart “all text widget variations” (center_aligned, right_aligned).
• _FakeTerminalPlatform. The signal-cleanup test now uses _RecordingTerminalPlatform(stdoutHasTerminal: false).

Strengthened

• Element depth calls _expectConsistentDepths.
• ScrollBox click hits an interior cell and expects offset 0 and an unconsumed event.
• FFI smoke reads the drawn cell and the filled rect before render.
• MainAxisSize.min pins height 10 and width 20. Those are the sizes layout produces.
• Loose flex offsets on a width-9 line: start 0, end 8, center 4, spaceBetween 0, spaceAround 4, spaceEvenly 4.
• Container color uses BufferMatchers.hasBackgroundAt.
• Native symbol init requires the static final to be _openValidatedForProcess(), open() to return it, and Renderer.create to construct bindings before createRenderer.
• Focus unfocus registers addTearDown for each caller-owned node and the app.
• Mouse scroll contract reads MouseScroll.direction and magnitude, and still rejects scrollDelta, MouseScrollAxis, and get axis in input.dart.

dart format and dart analyze --fatal-infos are clean. Full packages/noir suite: 2397 passed, 1 skipped, 8 failed before; 2380 passed, 1 skipped, 8 failed after. The same eight failures are missing external/opentui fixtures.

  

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-22T14:07:45.776889Z	fa64d2f	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.