Skip to content

chore: trim unused tooling and example chrome - #113

Draft
leoafarias wants to merge 1 commit into
mainfrom
cursor/cleanup-root-ci-examples-ad3d
Draft

leoafarias wants to merge 1 commit into
mainfrom
cursor/cleanup-root-ci-examples-ad3d

Conversation

@leoafarias

Copy link
Copy Markdown
Collaborator

Summary

  • Root and CI. The README license sentence is BSD 3-Clause and points at LICENSE. GOALS.md links to packages/noir/CHANGELOG.md. Removed .fvmrc, the six analyzer excludes for platforms that are not in the package, and the publish.yml preflight tarball nothing uploads. release.yml still builds the archive GitHub attaches.
  • Unused tools. Deleted tool/screenshot_iterm.sh (no callers) and tool/snapshot_scenes.dart, and dropped that path from the ownership existence list. Frozen changelog history is unchanged.
  • Inspector docs. Instructions use tool/ instead of tools/. The fixtures README lists many_tools_server and slow_server. FINDINGS.md drops closed entries 1–3, 15, and 25, plus the missing .context/terminal-evidence paths. Entries 16 and 24 stay.
  • Examples. Chat modals return the Panel. Pulse stays top-start. The file picker uses titled Project and Preview panels. image_demo and framework_primitives take chrome colors from Theme.of. The demo scaffold header is one sentence, and the duplicated // Run with: lines are gone. example/ and tool/ analysis options disable public_member_api_docs only; models.dart drops comments that restated the member and keeps real constraints (the pub-search allowlist among them).

Lines: −625 / +144

Golden: UPDATE_GOLDENS=1 dart test test/golden/chat_demo_golden_test.dart refreshed chat_demo_64x18 (buffer and styles). The permission panel no longer paints a full-width band, so the transcript shows beside it. The other two chat scenes were unchanged.

Proof

Dart SDK 3.10.0, from packages/noir:

  • dart format --output=none --set-exit-if-changed lib/ test/ example/ bin/ hook/ tool/
  • dart analyze --fatal-infos
  • dart test test/architecture/ --concurrency=1 — 264 passed
  • dart test test/example/ --concurrency=1 — 341 passed
Open in Web Open in Cursor 

Drop scripts and CI packaging nothing calls, correct the license and
changelog links, and bring catalog examples in line with the terminal
component language.

Co-authored-by: Leo Farias <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants