Repository navigation
Delete unused widget and painting API - #111
Merged
leoafarias merged 1 commit intoOct 22, 2026
Merged
leoafarias merged 1 commit into
leoafarias merged 1 commit into
Conversation
Remove obsolete prerelease shapes that nothing in the repo calls, and move ValueChanged next to VoidCallback. Co-authored-by: Leo Farias <[email protected]>
leoafarias
force-pushed
the
cursor/delete-dead-widget-painting-api-9fc6
branch
from
October 22, 2026 14:05
323762e to
8b0a270
Compare
leoafarias
changed the base branch from
main
to
cursor/second-sigint-kills-child-204f
October 22, 2026 14:05
leoafarias
marked this pull request as ready for review
October 22, 2026 14:05
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
leoafarias
added this pull request to stack #117
October 22, 2026 14:05
leoafarias
removed this pull request from stack #117
October 22, 2026 14:11
leoafarias
added this pull request to stack #118
October 22, 2026 14:12
leoafarias
added a commit
that referenced
this pull request
Oct 22, 2026
Prepare Noir 0.0.5. It adds TuiApp.copyToClipboard (#115); fixes paragraph alignment, character keys, cleared text edits, highlight ranges, Select and DiffView cell painting, and the hot-reload runner's second Ctrl+C (#105, #106, #110, #112); and removes unused prerelease API (#107, #111). The changelog names every removed public member, and the architecture test pins those release contracts. noir_driver 0.0.1-alpha.2 is already on pub.dev with noir: ^0.0.4, so its section stays as published and the driver moves to 0.0.1-alpha.3 to require noir: ^0.0.5. The unpublished noir_signals 0.0.1-alpha.2 now requires noir: ^0.0.5, with its checkout guidance. The native ABI and bundled native artifacts are unchanged from 0.0.4. Published availability stays at what publication.json records until protected publication confirms the new versions.
leoafarias
added a commit
that referenced
this pull request
Oct 23, 2026
Prepare Noir 0.0.5. It adds TuiApp.copyToClipboard (#115); fixes paragraph alignment, character keys, cleared text edits, highlight ranges, Select and DiffView cell painting, and the hot-reload runner's second Ctrl+C (#105, #106, #110, #112); and removes unused prerelease API (#107, #111). The changelog names every removed public member, and the architecture test pins those release contracts. Both companions leave alpha as 0.0.1 and require noir: ^0.0.5: noir_driver after the published 0.0.1-alpha.2, and noir_signals after the published 0.0.1-alpha.1. Neither library changed since those archives, and their changelog sections stay byte-for-byte as published. Noir's noir_driver dev dependency, the tag examples, the checkout guidance, and the testing page follow. publication.json now records noir_driver 0.0.1-alpha.2, which was published on 2026-10-19 when only its record step failed, and availability.ts is regenerated from it. Hosted install guidance keeps naming what pub.dev serves until protected publication confirms the new versions. The native ABI and bundled native artifacts are unchanged from 0.0.4.
leoafarias
added a commit
that referenced
this pull request
Oct 23, 2026
Prepare Noir 0.0.5. It adds TuiApp.copyToClipboard (#115); fixes paragraph alignment, character keys, cleared text edits, highlight ranges, Select and DiffView cell painting, and the hot-reload runner's second Ctrl+C (#105, #106, #110, #112); and removes unused prerelease API (#107, #111). The changelog names every removed public member, and the architecture test pins those release contracts. Both companions leave alpha as 0.0.1 and require noir: ^0.0.5: noir_driver after the published 0.0.1-alpha.2, and noir_signals after the published 0.0.1-alpha.1. Neither library changed since those archives, and their changelog sections stay byte-for-byte as published. Noir's noir_driver dev dependency, the tag examples, the checkout guidance, and the testing page follow. publication.json now records noir_driver 0.0.1-alpha.2, which was published on 2026-10-19 when only its record step failed, and availability.ts is regenerated from it. Hosted install guidance keeps naming what pub.dev serves until protected publication confirms the new versions. The native ABI and bundled native artifacts are unchanged from 0.0.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes obsolete prerelease widget and painting shapes. Each one was re-checked across lib, test, example, tool, website, and skills and had no callers.
DocumentViewportController, theDocumentView.controllerparameter,_jumpToLine, and the attach, swap, and detach hooks.BoxShape(includingBoxShape.circle) andBoxDecoration.shape. The barrel, the public API name list (251 symbols), and the widgets skill snippet drop it.Actions.find,Actions.invoke,Focus.of,Focus.maybeOf,FocusScope.of, andFocusScope.maybeOf. The private focus-ancestor walk existed only for those statics and went with them.OverlayPortalController.toggle.ValueChangedmoved fromtext_input.darttofoundation/listenable.dart, next toVoidCallback. It stays exported.Kept because they have callers:
Actions.maybeFind,Actions.maybeInvoke, and the unrelatedtogglemethods onTreeViewControllerand test harnesses.Diff: −203 / +20
Proof (Dart 3.10.0, from
packages/noir/):dart format --output=none --set-exit-if-changed lib/ test/ example/ bin/ hook/ tool/dart analyze --fatal-infosdart test --concurrency=1— 2408 passed, including architecture and public API tests