Repository navigation
refactor(tool): draw patch hunks without DiffView - #108
Draft
leoafarias wants to merge 1 commit into
Draft
leoafarias wants to merge 1 commit into
leoafarias wants to merge 1 commit into
Conversation
Hunk cards now use the same ScrollBox as whole-file cards, so the DiffView adapter and its controller are gone. Also drop the unreachable preview-only branches, the disabled failed-chip refresh action, and the unread MCP inspector instructions field. Co-authored-by: Leo Farias <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunk cards now scroll on the same
ScrollBoxas whole-file cards. Removed theDiffViewadapter,DiffViewController, and thenoir_diffimport. The git parser,GitPath, andPatchGeneratorstay.Also removed the unreachable preview-only and no-reviewable branches, the disabled failed chip's refresh wiring (
PatchActionKind.refresh;rstill refreshes), the stale status-legend comment, and the unread MCP inspectorinstructionsfield.48 insertions, 177 deletions.
Proof:
dart format --output=none --set-exit-if-changed lib/ test/ example/ bin/ hook/ tool/frompackages/noir— 539 files, 0 changeddart analyze --fatal-infosinpackages/noirandtool/mcp_inspector— no issuesdart test --concurrency=1intool/mcp_inspector— passeddart test test/architecture --concurrency=1— 264 passed