Repository navigation
Delete unused core and foundation API - #107
Draft
leoafarias wants to merge 1 commit into
Draft
leoafarias wants to merge 1 commit into
leoafarias wants to merge 1 commit into
Conversation
Remove prerelease shapes with no callers: Color.withOpacity, Listenable.merge, TextRange textBefore/textAfter/isNormalized, TextEditingValue.composing, CursorController.updatePosition, PersistentUtf8Text, TERMINAL_TUI_DEBUG_LOG, and FocusAttachment.isScope. Co-authored-by: Leo Farias <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes dead prerelease API. Each item was re-grepped across lib, test, example, tool, website, and skills; nothing real still calls it.
Removed:
Color.withOpacity, plus the stale ColorPalette sentenceListenable.mergeand_MergingListenable, and that test groupTextRange.textBefore,textAfter, andisNormalized, and their testsTextEditingValue.composingand its testsCursorController.updatePosition(the low-level barrel still exportsCursorController)PersistentUtf8Text, its unit test, and the snippet lock innative_lifecycle_test.dartTERMINAL_TUI_DEBUG_LOGand thedart:ioimport that only served itFocusAttachment.isScopeand the unreadelementgetternoir_ffi.dartimport inbin/health_check.dartKept
Color.lerp, the*Transparentconstants,TextRange.textInsideandisValid, andFocusAttachment.isAttached. ThePersistentUtf8Textdenylist strings inpublic_api_testandsource_package_consumer_teststay.14 insertions, 330 deletions.
Proof, Dart 3.10.0, from
packages/noir:dart format --output=none --set-exit-if-changed lib/ test/ example/ bin/ hook/ tool/dart analyze --fatal-infosdart test --concurrency=1— 2389 passed. Eight failures and one skip were the uninitializedexternal/opentuisubmodule (missing fixtures andgit rev-parsewalking up to this repo). Aftergit submodule update --init, those tests pass.