Repository navigation
fix(ack): accept Draft-07 $schema URI and remove dead prefixItems index - #217
Merged
leoafarias merged 1 commit intoOct 9, 2026
Conversation
leoafarias
force-pushed
the
leoafarias/json-schema-import-draft07-uri
branch
from
October 8, 2026 22:01
385d3c2 to
5b64f3c
Compare
leoafarias
force-pushed
the
leoafarias/json-schema-import-draft07-uri
branch
2 times, most recently
from
October 9, 2026 02:26
f56b1a8 to
c1cafb9
Compare
leoafarias
added this pull request to stack #218
October 9, 2026 12:33
leoafarias
force-pushed
the
leoafarias/json-schema-import-draft07-uri
branch
from
October 9, 2026 12:46
c1cafb9 to
dbaa948
Compare
leoafarias
force-pushed
the
leoafarias/json-schema-import-draft07-uri
branch
from
October 9, 2026 13:10
dbaa948 to
ac0b4ba
Compare
leoafarias
force-pushed
the
leoafarias/json-schema-import-draft07-uri
branch
from
October 9, 2026 13:29
ac0b4ba to
fee90fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Stacked on #216 (
leoafarias/json-schema-import-builtin-formats)._JsonSchemaCompilerin1.7.xalready supports Draft-07definitionsalongside Draft 2020-12$defs(andschema.toJsonSchema()emits Draft-07 shapes), but_JsonSchemaCompiler._indexrejected documents that explicitly declared the Draft-07$schemaURI (http(s)://json-schema.org/draft-07/schema(#)) withunsupported_dialect. In addition,listKeywordsin_JsonSchemaCompilerstill contained an unused'prefixItems'entry even thoughprefixItemsvalidation is deferred to2.0(#171).Scope
http(s)://json-schema.org/draft-07/schema(#)alongsidehttps://json-schema.org/draft/2020-12/schema(#)in_JsonSchemaCompiler.supportedSchemaDialectsso Draft-07 schemas using Ack's supported subset import cleanly without stripping$schema.'prefixItems'entry from_JsonSchemaCompiler.listKeywordssoprefixItemsfails directly withunsupported_keywordwithout being indexed as a child schema list.docs/guides/json-schema-integration.mdxandpackages/ack/CHANGELOG.md(## Unreleased).Verification
fvm dart analyzeinpackages/ackreports no issues.fvm dart test test/json_schema_import_test.dart test/json_schema_import_api_test.dart test/json_schema_import_conformance_test.dartpasses.