Repository navigation
test(ack): pin Draft 2020-12 conformance fixtures - #169
Merged
Merged
Conversation
This was referenced Sep 28, 2026
leoafarias
added this pull request to stack #170
September 28, 2026 22:38
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review order
This is the base of a review stack: #169 → #167 → #168. The fixture files are byte-identical across the branches, and #167/#168 now exclude them from their own diffs. Merge in that order, retargeting each successor to
mainafter its base merges. Executable Ack validation/export and generated-model conformance tests remain in #167: they require its implementation and cannot pass against currentmainindependently.Validation
dart run melos run analyze --no-select— passed.dart testinpackages/ack— 1,311 tests passed, including fixture integrity.dart test test/integration/model_generation_guide_build_test.dartinpackages/ack_generator— passed.git diff --check— passed.