Repository navigation
Conversation
Bring the docs in sync with the shipped 003 interactive deck (and the #226 Skills rework). - docs/architecture.md — rewrote "Template & styling" for the full-viewport scroll-snap deck, card rails + :target detail overlays, the Through-Line, and the pure-CSS swipe affordance; added deck.js/overlay.js and the vendored screen-only Fraunces + Spline Sans; fixed the `skills` data-model row (now `[{category, kind, items}]`, no proficiency %); noted pdf-visual.spec.js. - docs/adr/0004-native-scroll-snap-editorial-deck.md (NEW) — the decision to build the CV as a native-scroll-snap deck (rails + :target overlays, screen-only, one signature). Records that decision 5 REVERSES ADR 0003's "pdf.js unchanged (no emulateMedia)" — pdf.js now emulates print media before navigating — and links the fullPage-gate trade-off to the open follow-ups (#225/#221/#223). - docs/adr/README.md — indexed 0004; docs/adr/0003 — added an "Update (003)" note scoping what changed (decision 2) vs what stands (1 and 3). Verified factually accurate against the shipped code (two review passes, clean); markdownlint clean; all cross-doc links resolve. Closes #210 Closes #211
|
🔺 Vercel preview: https://cv-cm4lo769s-bruno-valerios-projects.vercel.app commit |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the last two milestone-003 tasks — the docs that shipped after the implementation. Closes #210, Closes #211.
docs/architecture.md(#210)Brought in sync with the shipped deck (and the #226 Skills rework):
:targetdetail overlays, the Through-Line signature, and the pure-CSS swipe affordance; documenteddeck.js/overlay.js/reveal.js.skillsdata-model row (now[{ category, kind, items }], no proficiency %); notedpdf-visual.spec.jsin the layout + Tests.docs/adr/0004-native-scroll-snap-editorial-deck.md(#211, NEW)The decision to build the CV as a native-scroll-snap deck (rails +
:targetoverlays, screen-only, one signature). Notably records that decision 5 reverses ADR 0003's "pdf.jsunchanged (noemulateMedia)" —pdf.jsnow emulates print media before navigating — and ties the tall-fullPage-gate trade-off to the open follow-ups (#225/#221/#223). Indexed indocs/adr/README.md; added an "Update (003)" back-reference note to ADR 0003 scoping what changed (decision 2) vs what stands (1 and 3).Verification
Two review passes confirmed every architecture.md claim is true against the shipped code and ADR 0004 is accurate/consistent. markdownlint clean; all cross-doc links resolve. Docs-only — no site/PDF impact.
Merging this closes milestone 003 (last 2 of 30 issues).
🤖 Generated with Claude Code