Repository navigation
Conversation
Fills the a11y gaps across the deck/rails/overlays (deck keyboard nav, overlay focus trap/return, and the :target no-JS baseline were already in place from US1/US2). - Reduced motion (FR-014): a @media (prefers-reduced-motion: reduce) block now also suppresses the US2 rail/overlay animation (summary hover-lift, overlay fade + card scale-in) — an overlay opens instantly and stays fully functional. (Deck glide + reveal were already gated; snapping is a resting position, kept.) - Visible focus (WCAG 2.4.7): focus-visible outlines on summary cards, the overlay close, and nav links; rails already use scroll-padding-inline so the ring isn't clipped. - Landmarks/labels: each section is now a labelled region (aria-labelledby -> its h2 id); each rail is a labelled list (aria-label). - Overlay backdrops are non-tabbable (tabindex=-1, aria-hidden) — a mouse/no-JS click-outside affordance; the visible close x (a real #section anchor) is the keyboard/AT/no-JS close control. overlay.js's focus-trap now filters tabIndex >= 0 so the backdrop isn't a phantom full-screen stop. Screen-only; PDF unchanged. Verified in the pinned image: make visual 8/8, baselines unchanged (aria/focus/reduced-motion don't alter the resting render). Lint verified directly (overlay.js standard-clean, styles.css stylelint-clean); code-reviewed — no findings. Closes #201 Closes #202 Closes #203 Closes #204 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
🔺 Vercel preview: https://cv-k9oa79hzg-bruno-valerios-projects.vercel.app commit |
brunogbv
added a commit
that referenced
this pull request
Jul 4, 2026
Ships feature 003 (interactive editorial deck: full-viewport snap sections, summary-card rails + detail overlays, editorial restyle with vendored fonts, a11y/no-JS/reduced-motion, and the Through-Line signature) plus the US2 detail-overlay interaction fix. Screen-only; PDF unchanged. Integration branch 003-deck (US1 #214, US3+US2 #217/#218, US4 #219, US5 #220, overlay fix e5e713e).
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fills the accessibility gaps across the deck / rails / overlays. Deck keyboard nav, overlay focus
trap+return, and the
:targetno-JS baseline were already in place (US1/US2) — this hardens the rest.Closes #201, #202, #203, #204.
Changes
@media (prefers-reduced-motion: reduce)block now also suppresses theUS2 rail/overlay animation (summary hover-lift, overlay fade + card scale-in) — an overlay opens
instantly and stays fully functional. Snapping is a resting position (kept); deck glide + reveal were
already gated.
links (rails use
scroll-padding-inlineso the ring isn't clipped).aria-labelledby→ its<h2>id); each railis a labelled list (
aria-label).tabindex="-1" aria-hidden="true"— amouse/no-JS click-outside affordance; the visible close × (a real
#sectionanchor) is thekeyboard/AT/no-JS close control.
overlay.js's focus-trap now filterstabIndex >= 0so the backdropisn't a phantom full-screen tab stop.
Verification
make visual8/8, baselines unchanged (aria/focus/reduced-motion don't alter theresting render or the PDF).
overlay.jsStandard-clean,styles.cssstylelint-clean.backdrop exclusion keeps mouse-close working; all
aria-labelledbyreferences resolve).Scope
Into
003-deck(integration branch — no production deploy). Only US5 (the Through-Line signature)remains; then
003-deck→mainships the full redesign.🤖 Generated with Claude Code