docs: record that TMD was Transmembrane Domain before it was Target Middle Domain - #591
Open
breimanntools wants to merge 1 commit into
Open
breimanntools wants to merge 1 commit into
breimanntools wants to merge 1 commit into
Conversation
…iddle Domain The wording added earlier today said TMD means Target Middle Domain "not transmembrane domain". That flattens a design decision into a correction, and it is wrong in the one place it matters most: in the gamma-secretase work the span really is the transmembrane domain. The history is the explanation. CPP was first applied to gamma-secretase substrates, where the span of interest is the transmembrane domain and its flanks are the juxtamembrane domains. When the method was generalized beyond membrane proteins the acronyms were deliberately kept and re-read - TMD as Target Middle Domain, JMD as Juxta Middle Domain. Same letters, same geometry, wider meaning, nothing to rename per data set. Stated in the three places a reader meets it: - the Feature Identification chapter, whose admonition now leads with the origin and says a feature id describes a transmembrane helix only when the data are membrane proteins, as in the case study below it - the part entry in CONTEXT.md, the internal glossary that caused the region-renaming proposals in the first place - the gamma-secretase use case, right where the reader meets jmd_n / tmd / jmd_c, since that analysis is the one the vocabulary is named after and the literal reading is the correct one there Documentation only. The notebook change is a markdown cell, so its executed outputs are untouched. Docs gate: 0 errors, critical at baseline. Co-Authored-By: Claude Fable 5.1 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 222 222
Lines 23387 23387
Branches 4073 4073
=======================================
Hits 22309 22309
Misses 631 631
Partials 447 447
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wording added earlier said TMD means Target Middle Domain "not transmembrane domain". That flattens a design decision into a correction — and it is wrong in the one place it matters most: in the γ-secretase work the span really is the transmembrane domain.
The history is the explanation. CPP was first applied to γ-secretase substrates, where the span of interest is the transmembrane domain and its flanks are the juxtamembrane domains. When the method was generalized beyond membrane proteins the acronyms were deliberately kept and re-read — TMD as Target Middle Domain, JMD as Juxta Middle Domain. Same letters, same geometry, wider meaning, nothing to rename per data set.
Stated in the three places a reader meets it:
partentry inCONTEXT.md, the internal glossary whose earlier wording generated the region-renaming proposals in the first placejmd_n/tmd/jmd_c, since that analysis is the one the vocabulary is named after and the literal reading is the correct one thereDocumentation only. The notebook change is a markdown cell, so its executed outputs are untouched. Docs gate: 0 errors, critical at baseline (167).
Context: #27 was closed on this basis.
🤖 Generated with Claude Code