docs: TMD means Target Middle Domain, and it is already the abstraction - #586
Merged
Merged
Conversation
The published Feature Identification chapter has always said "Target Middle Domain (TMD)". The glossaries had drifted away from it: CONTEXT.md called the part vocabulary "TMD-centric" and "semantically wrong" for non-domain levels and told the reader to "replace the generic tmd with the specific domain name", and docs/source/index/glossary.rst said the same. Read literally, that describes a defect, so it kept generating proposals to add a region-naming layer to CPP. Three independent planning passes - a codex planner, a subagent and this session - each reached that same wrong conclusion from the text alone, and each designed a region= parameter, a rename mapping and a place to store it. There is nothing to rename. The vocabulary is a geometry: one target middle domain flanked by two juxta middle domains, which applies unchanged to a Pfam domain, a cleavage-site window or a whole chain. A feature id reading TMD-Segment(2,4)-ANDN920101 does not assert a transmembrane helix. So the statement now appears in six places, all pointing at one canon: - feature_identification.rst gains an `important` admonition and the `part_vocabulary` anchor (and a JMD-C typo fix: it read "N-terminal") - glossary.rst: the part and df_parts entries, cross-referencing the anchor - CONTEXT.md: the part entry, with a note that it had drifted - _schemas.py: the df_parts description, rendered into the schema page - _constants.py: the comment above DICT_PART_LABEL, replacing the stale "reserved for the #27 region abstraction" note - CLAUDE.md: an always-loaded rule, so an agent reads it before designing Comment and description strings only in the two Python files; no code changed, and CPP is untouched. df_schemas.rst is regenerated from the edited schema so its sync test passes. Co-Authored-By: Claude Fable 5.1 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #586 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 222 222
Lines 23387 23387
Branches 4073 4073
=======================================
Hits 22309 22309
Misses 631 631
Partials 447 447
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published Feature Identification chapter has always said Target Middle Domain (TMD). The glossaries had drifted away from it.
CONTEXT.mdcalled the part vocabulary "TMD-centric" and "semantically wrong" for non-domain levels, and told the reader to "replace the generictmdwith the specific domain name".docs/source/index/glossary.rstsaid the same.Read literally, that describes a defect — so it kept generating proposals to add a region-naming layer to CPP. Three independent planning passes (a codex planner, a subagent, and this session) each reached that conclusion from the text alone, and each designed a
region=parameter, a rename mapping, and somewhere to store it. The maintainer stopped it before a line was written.There is nothing to rename. The vocabulary is a geometry: one target middle domain flanked by two juxta middle domains, applying unchanged to a Pfam domain, a cleavage-site window or a whole chain. A feature id reading
TMD-Segment(2,4)-ANDN920101does not assert a transmembrane helix.Stated in six places, all pointing at one canon
usage_principles/feature_identification.rstimportantadmonition and thepart_vocabularyanchor (plus a JMD-C typo fix: it read "N-terminal")glossary.rstpartanddf_partsentries, cross-referencing the anchorCONTEXT.mdpartentry, and a note that it had drifted from the published chapter_schemas.pydf_partsdescription, rendered into the schema page_constants.pyDICT_PART_LABEL, replacing the stale "reserved for the #27 region abstraction" noteCLAUDE.mdComment and description strings only in the two Python files — no code changed, CPP untouched.
df_schemas.rstis regenerated from the edited schema so its sync test passes (341 API tests green).🤖 Generated with Claude Code