Skip to content

chore(deps): upgrade G2 — test stack - #48

Closed
bravew wants to merge 2 commits into
mainfrom
chore/upgrade-G2-tests-2026-09-27
Closed

bravew wants to merge 2 commits into
mainfrom
chore/upgrade-G2-tests-2026-09-27

Conversation

@bravew

@bravew bravew commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

Group 2 of the 2026-09-27 dependency sweep (dev-doc/plan/_module-lib-upgrade.md rev 4).

Package Workspaces Before After
@playwright/test root ^1.62.1 ^1.63.0
playwright src-video ^1.62.1 ^1.63.0
@testing-library/react root ^16.3.2 ^16.3.3
@testing-library/user-event root ^14.6.5 ^14.6.7
jsdom root ^30.0.1 ^30.1.1

The lockfile also refreshes the transitive @csstools/css-parser-algorithms to 4.0.1. jsdom 30.1's @csstools/css-calc needs ^4.0.1, and pnpm had kept 4.0.0.

Held: vitest 5. It installs and all tests pass at runtime, but typecheck picks up about 680 new errors. @testing-library/jest-dom 7.0.1 (the latest release) augments Assertion<T>, which no longer merges with Vitest 5's Assertion<R, T>, so every jest-dom matcher (toBeInTheDocument, etc.) loses its type. The upstream issue is jest-dom#738, with a fix in jest-dom#742 that hasn't merged. @copilotkit/channels-core's latest release also still declares a vitest ^4 peer. Worth retrying once jest-dom ships Vitest 5 support.

Test plan

main already fails typecheck (1), format (3 fixtures), API lint (4), test:e2e (1), and test:e2e:browser (23). This branch produces identical results everywhere.

  • pnpm install: clean, 0 peer warnings
  • pnpm typecheck:all, lint, API lint, format:check: same as baseline
  • pnpm test:fast: 1453 frontend + 3533 API tests passed (7 skipped)
  • pnpm test:e2e:browser on Playwright 1.63: 23 failed / 25 passed / 9 skipped, the same 23 as the baseline on Playwright 1.62.1. Both runs served the worktree frontend on port 3520, which the API's hardcoded CORS allow-list (3420 only) rejects, and neither was actually isolated: src-api/src/shared/db/index.ts opens $HOME/.neumar/database.db and ignores NEUMAR_APP_DATA_DIR. Treat this as a like-for-like comparison, not a meaningful pass/fail signal.
  • pnpm test:e2e: only video-plan-resume fails, and it also fails on the baseline
  • pnpm audit --audit-level moderate: 7, unchanged; signatures 2148/2148 verified

@playwright/test and playwright 1.62.1 → 1.63.0, @testing-library/react
16.3.2 → 16.3.3, @testing-library/user-event 14.6.5 → 14.6.7, jsdom
30.0.1 → 30.1.1. Refreshes the transitive
@csstools/css-parser-algorithms to 4.0.1 so jsdom's css-calc peer is met.

Held: vitest 5. @testing-library/jest-dom 7.0.1 still augments
Assertion<T>, which no longer merges with Vitest 5's Assertion<R, T>, so
~680 jest-dom matcher type errors appear (jest-dom #738, fix PR #742
open). @copilotkit/channels-core's latest release also peers vitest ^4.

Gate: install clean, no peer warnings; typecheck/lint/format identical
to the main baseline; test:fast 1453 + 3533 passed; browser and API e2e
failures identical to the baseline (23 and 1, pre-existing); audit
unchanged at 7; signatures 2148/2148 verified.
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ac517390-7db2-49cf-96cb-ad10612c68f7

📥 Commits

Reviewing files that changed from the base of the PR and between 7b26dc2 and 491848f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • src-video/package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bravew bravew mentioned this pull request Sep 27, 2026
2 of 3 tasks
@bravew

bravew commented Sep 27, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #61, which lands G2–G14 as one commit.

@bravew bravew closed this Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant