Repository navigation
Conversation
@playwright/test and playwright 1.62.1 → 1.63.0, @testing-library/react 16.3.2 → 16.3.3, @testing-library/user-event 14.6.5 → 14.6.7, jsdom 30.0.1 → 30.1.1. Refreshes the transitive @csstools/css-parser-algorithms to 4.0.1 so jsdom's css-calc peer is met. Held: vitest 5. @testing-library/jest-dom 7.0.1 still augments Assertion<T>, which no longer merges with Vitest 5's Assertion<R, T>, so ~680 jest-dom matcher type errors appear (jest-dom #738, fix PR #742 open). @copilotkit/channels-core's latest release also peers vitest ^4. Gate: install clean, no peer warnings; typecheck/lint/format identical to the main baseline; test:fast 1453 + 3533 passed; browser and API e2e failures identical to the baseline (23 and 1, pre-existing); audit unchanged at 7; signatures 2148/2148 verified.
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Superseded by #61, which lands G2–G14 as one commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Group 2 of the 2026-09-27 dependency sweep (
dev-doc/plan/_module-lib-upgrade.mdrev 4).The lockfile also refreshes the transitive
@csstools/css-parser-algorithmsto 4.0.1. jsdom 30.1's@csstools/css-calcneeds^4.0.1, and pnpm had kept 4.0.0.Held: vitest 5. It installs and all tests pass at runtime, but typecheck picks up about 680 new errors.
@testing-library/jest-dom7.0.1 (the latest release) augmentsAssertion<T>, which no longer merges with Vitest 5'sAssertion<R, T>, so every jest-dom matcher (toBeInTheDocument, etc.) loses its type. The upstream issue is jest-dom#738, with a fix in jest-dom#742 that hasn't merged.@copilotkit/channels-core's latest release also still declares avitest ^4peer. Worth retrying once jest-dom ships Vitest 5 support.Test plan
mainalready fails typecheck (1), format (3 fixtures), API lint (4),test:e2e(1), andtest:e2e:browser(23). This branch produces identical results everywhere.pnpm install: clean, 0 peer warningspnpm typecheck:all, lint, API lint,format:check: same as baselinepnpm test:fast: 1453 frontend + 3533 API tests passed (7 skipped)pnpm test:e2e:browseron Playwright 1.63: 23 failed / 25 passed / 9 skipped, the same 23 as the baseline on Playwright 1.62.1. Both runs served the worktree frontend on port 3520, which the API's hardcoded CORS allow-list (3420 only) rejects, and neither was actually isolated:src-api/src/shared/db/index.tsopens$HOME/.neumar/database.dband ignoresNEUMAR_APP_DATA_DIR. Treat this as a like-for-like comparison, not a meaningful pass/fail signal.pnpm test:e2e: onlyvideo-plan-resumefails, and it also fails on the baselinepnpm audit --audit-level moderate: 7, unchanged; signatures 2148/2148 verified